public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 07/32] nitrogen6x: Allow U-Boot to be silent on UART2
Date: Mon, 06 Oct 2014 08:51:57 -0700	[thread overview]
Message-ID: <5432BA9D.6030507@boundarydevices.com> (raw)
In-Reply-To: <5432B869.1020007@denx.de>

Thanks Stefano,

On 10/06/2014 08:42 AM, Stefano Babic wrote:
> Hi Eric,
> 
> On 02/10/2014 21:16, Eric Nelson wrote:
>> Several customers are using UART2 (normally the serial console
>> for U-Boot) as connections to printers or other peripherals
>> that are not tolerant of stray inputs during reset.
>>
>> Provide a simple way to eliminate output on the serial port
>> by conditionally configuring these pads as GPIOs during
>> U-Boot.
>>
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>> ---
>>  board/boundary/nitrogen6x/nitrogen6x.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/board/boundary/nitrogen6x/nitrogen6x.c b/board/boundary/nitrogen6x/nitrogen6x.c
>> index e795492..621cdbc 100644
>> --- a/board/boundary/nitrogen6x/nitrogen6x.c
>> +++ b/board/boundary/nitrogen6x/nitrogen6x.c
>> @@ -77,9 +77,15 @@ static iomux_v3_cfg_t const uart1_pads[] = {
>>  	MX6_PAD_SD3_DAT7__UART1_TX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
>>  };
>>  
>> +/* #define CONFIG_SILENT_UART */
> 
> Theoretically, we have already in U-Boot CONFIG_SILENT_CONSOLE, without
> the need to introduce a new CONFIG_.
> 
>>  static iomux_v3_cfg_t const uart2_pads[] = {
>> +#ifndef CONFIG_SILENT_UART
>>  	MX6_PAD_EIM_D26__UART2_TX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
>>  	MX6_PAD_EIM_D27__UART2_RX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
>> +#else
>> +	MX6_PAD_EIM_D26__GPIO3_IO26 | MUX_PAD_CTRL(UART_PAD_CTRL),
>> +	MX6_PAD_EIM_D27__GPIO3_IO27 | MUX_PAD_CTRL(UART_PAD_CTRL),
>> +#endif
> 
> I understand the reason, anyway this looks like a hack (uart is still
> configured while iomux is not correctly set). Can you check if your goal
> is simply reached with CONFIG_SILENT_CONSOLE ?
> 
Will do. I wasn't aware of that one.

Regards,


Eric

  reply	other threads:[~2014-10-06 15:51 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 19:16 [U-Boot] [PATCH 00/32] ARM: i.MX: nitrogen6x clean up Eric Nelson
2014-10-02 19:16 ` [U-Boot] [PATCH 01/32] nitrogen6x: implement board_cfb_skip() to disable text output Eric Nelson
2014-10-06 15:58   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 02/32] nitrogen6x: simplify board_mmc_getcd Eric Nelson
2014-10-06 15:58   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 03/32] nitrogen6x: configure SD2 pads for SDIO on USDHC2 Eric Nelson
2014-10-06 16:01   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 04/32] nitrogen6x: power-down miscellanous peripherals Eric Nelson
2014-10-06 16:01   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 05/32] nitrogen6x: configure SGTL5000, CSI camera clock outputs Eric Nelson
2014-10-06 16:01   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 06/32] nitrogen6x: staticize board file Eric Nelson
2014-10-06 16:02   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 07/32] nitrogen6x: Allow U-Boot to be silent on UART2 Eric Nelson
2014-10-06 15:42   ` Stefano Babic
2014-10-06 15:51     ` Eric Nelson [this message]
2014-10-02 19:16 ` [U-Boot] [PATCH 08/32] nitrogen6x: phy: add 100 us delay after phy reset Eric Nelson
2014-10-06 16:02   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 09/32] nitrogen6x: prevent warnings about board_ehci* callbacks Eric Nelson
2014-10-06 16:03   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 10/32] nitrogen6x: display: add support lvds jeida screen Eric Nelson
2014-10-06 16:04   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 11/32] nitrogen6x: display: add qvga panel Eric Nelson
2014-10-06 16:04   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 12/32] nitrogen6x: display: add support for LG-9.7 LVDS display Eric Nelson
2014-10-06 16:05   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 13/32] nitrogen6x: display: add LDB-WXGA-S for SPWG 1280x800 displays Eric Nelson
2014-10-06 16:05   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 14/32] nitrogen6x: display: add support for fusion 7 display Eric Nelson
2014-10-06 16:05   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 15/32] nitrogen6x: display: add svga display (800x600) Eric Nelson
2014-10-06 16:06   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 16/32] nitrogen6x: display: add Ampire 1024x600 panel Eric Nelson
2014-10-06 16:06   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 17/32] nitrogen6x: display: add wvga-lvds panel Eric Nelson
2014-10-06 16:06   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 18/32] nitrogen6x: display use I2C detect for HDMI Eric Nelson
2014-10-06 16:07   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 19/32] nitrogen6x: config: add USB Mass Storage (ums) support Eric Nelson
2014-10-06 16:07   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 20/32] nitrogen6x: config: allow boot to USB stick Eric Nelson
2014-10-06 16:07   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 21/32] nitrogen6x: config: use FS_GENERIC load command Eric Nelson
2014-10-06 16:07   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 22/32] nitrogen6x: config: add initrd_high Eric Nelson
2014-10-06 16:08   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 23/32] nitrogen6x: config: expose SATA, then MMC over USB Eric Nelson
2014-10-06 16:08   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 24/32] nitrogen6x: config: enable USB keyboard support Eric Nelson
2014-10-06 16:08   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 25/32] nitrogen6x: config: add CONFIG_CMD_MEMTEST Eric Nelson
2014-10-06 16:08   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 26/32] nitrogen6x: config: enable "i2c edid" Eric Nelson
2014-10-06 16:08   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 27/32] nitrogen6x: config: allow more bootargs parameters Eric Nelson
2014-10-06 16:09   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 28/32] nitrogen6x: config: disable logo Eric Nelson
2014-10-06 15:51   ` Stefano Babic
2014-10-06 16:09   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 29/32] nitrogen6x: config: configure usb_ether Eric Nelson
2014-10-06 15:54   ` Stefano Babic
2014-10-06 16:41     ` Eric Nelson
2014-10-07 14:36       ` Stefano Babic
2014-10-07 15:08         ` Eric Nelson
2014-10-02 19:16 ` [U-Boot] [PATCH 30/32] nitrogen6x: config: add gpio command Eric Nelson
2014-10-06 16:09   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 31/32] nitrogen6x: config: enable Android fastboot Eric Nelson
2014-10-06 16:09   ` Stefano Babic
2014-10-02 19:16 ` [U-Boot] [PATCH 32/32] nitrogen6x: config: enable EXT4 filesystem Eric Nelson
2014-10-06 16:10   ` Stefano Babic
2014-10-06 15:35 ` [U-Boot] [PATCH 00/32] ARM: i.MX: nitrogen6x clean up Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5432BA9D.6030507@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox