* [U-Boot] [PATCH] compulab: eeprom: add default eeprom bus
@ 2014-09-17 12:59 Nikita Kiryanov
2014-09-17 14:18 ` Igor Grinberg
2014-10-09 8:50 ` Albert ARIBAUD
0 siblings, 2 replies; 7+ messages in thread
From: Nikita Kiryanov @ 2014-09-17 12:59 UTC (permalink / raw)
To: u-boot
Add default eeprom bus setting.
This addresses the trimslice compile error that was introduced
with the addition of this setting.
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Cc: Igor Grinberg <grinberg@compulab.co.il>
Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
---
board/compulab/common/eeprom.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/board/compulab/common/eeprom.c b/board/compulab/common/eeprom.c
index 85442cd..2df3ada 100644
--- a/board/compulab/common/eeprom.c
+++ b/board/compulab/common/eeprom.c
@@ -15,6 +15,10 @@
# define CONFIG_SYS_I2C_EEPROM_ADDR_LEN 1
#endif
+#ifndef CONFIG_SYS_I2C_EEPROM_BUS
+#define CONFIG_SYS_I2C_EEPROM_BUS 0
+#endif
+
#define EEPROM_LAYOUT_VER_OFFSET 44
#define BOARD_SERIAL_OFFSET 20
#define BOARD_SERIAL_OFFSET_LEGACY 8
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] compulab: eeprom: add default eeprom bus
2014-09-17 12:59 [U-Boot] [PATCH] compulab: eeprom: add default eeprom bus Nikita Kiryanov
@ 2014-09-17 14:18 ` Igor Grinberg
2014-09-18 12:26 ` Albert ARIBAUD
2014-10-09 8:50 ` Albert ARIBAUD
1 sibling, 1 reply; 7+ messages in thread
From: Igor Grinberg @ 2014-09-17 14:18 UTC (permalink / raw)
To: u-boot
On 09/17/14 15:59, Nikita Kiryanov wrote:
> Add default eeprom bus setting.
> This addresses the trimslice compile error that was introduced
> with the addition of this setting.
>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> Cc: Igor Grinberg <grinberg@compulab.co.il>
> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
Albert, this should be a temporary fix to not break the trimslice support.
We intend to rework this while switching Kconfig for all boards.
Thanks!
> ---
> board/compulab/common/eeprom.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/board/compulab/common/eeprom.c b/board/compulab/common/eeprom.c
> index 85442cd..2df3ada 100644
> --- a/board/compulab/common/eeprom.c
> +++ b/board/compulab/common/eeprom.c
> @@ -15,6 +15,10 @@
> # define CONFIG_SYS_I2C_EEPROM_ADDR_LEN 1
> #endif
>
> +#ifndef CONFIG_SYS_I2C_EEPROM_BUS
> +#define CONFIG_SYS_I2C_EEPROM_BUS 0
> +#endif
> +
> #define EEPROM_LAYOUT_VER_OFFSET 44
> #define BOARD_SERIAL_OFFSET 20
> #define BOARD_SERIAL_OFFSET_LEGACY 8
>
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] compulab: eeprom: add default eeprom bus
2014-09-17 14:18 ` Igor Grinberg
@ 2014-09-18 12:26 ` Albert ARIBAUD
2014-09-18 13:21 ` Nikita Kiryanov
0 siblings, 1 reply; 7+ messages in thread
From: Albert ARIBAUD @ 2014-09-18 12:26 UTC (permalink / raw)
To: u-boot
Hi Igor,
On Wed, 17 Sep 2014 17:18:49 +0300, Igor Grinberg
<grinberg@compulab.co.il> wrote:
> On 09/17/14 15:59, Nikita Kiryanov wrote:
> > Add default eeprom bus setting.
> > This addresses the trimslice compile error that was introduced
> > with the addition of this setting.
> >
> > Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> > Cc: Igor Grinberg <grinberg@compulab.co.il>
> > Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
>
> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
>
> Albert, this should be a temporary fix to not break the trimslice support.
> We intend to rework this while switching Kconfig for all boards.
>
> Thanks!
>
> > ---
> > board/compulab/common/eeprom.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/board/compulab/common/eeprom.c b/board/compulab/common/eeprom.c
> > index 85442cd..2df3ada 100644
> > --- a/board/compulab/common/eeprom.c
> > +++ b/board/compulab/common/eeprom.c
> > @@ -15,6 +15,10 @@
> > # define CONFIG_SYS_I2C_EEPROM_ADDR_LEN 1
> > #endif
> >
> > +#ifndef CONFIG_SYS_I2C_EEPROM_BUS
> > +#define CONFIG_SYS_I2C_EEPROM_BUS 0
> > +#endif
> > +
> > #define EEPROM_LAYOUT_VER_OFFSET 44
> > #define BOARD_SERIAL_OFFSET 20
> > #define BOARD_SERIAL_OFFSET_LEGACY 8
> >
a 'git grep CONFIG_SYS_I2C_EEPROM_BUS' shows that all values for
CONFIG_SYS_I2C_EEPROM_BUS are set in include/configs/*.h.
Therefore I would prefer that the temporary fix be in
include/configs/trimslice.h header file too.
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] compulab: eeprom: add default eeprom bus
2014-09-18 12:26 ` Albert ARIBAUD
@ 2014-09-18 13:21 ` Nikita Kiryanov
2014-09-18 20:35 ` Albert ARIBAUD
0 siblings, 1 reply; 7+ messages in thread
From: Nikita Kiryanov @ 2014-09-18 13:21 UTC (permalink / raw)
To: u-boot
Hi ALbert,
On 18/09/14 15:26, Albert ARIBAUD wrote:
> Hi Igor,
>
> On Wed, 17 Sep 2014 17:18:49 +0300, Igor Grinberg
> <grinberg@compulab.co.il> wrote:
>
>> On 09/17/14 15:59, Nikita Kiryanov wrote:
>>> Add default eeprom bus setting.
>>> This addresses the trimslice compile error that was introduced
>>> with the addition of this setting.
>>>
>>> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
>>> Cc: Igor Grinberg <grinberg@compulab.co.il>
>>> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
>>
>> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
>>
>> Albert, this should be a temporary fix to not break the trimslice support.
>> We intend to rework this while switching Kconfig for all boards.
>>
>> Thanks!
>>
>>> ---
>>> board/compulab/common/eeprom.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/board/compulab/common/eeprom.c b/board/compulab/common/eeprom.c
>>> index 85442cd..2df3ada 100644
>>> --- a/board/compulab/common/eeprom.c
>>> +++ b/board/compulab/common/eeprom.c
>>> @@ -15,6 +15,10 @@
>>> # define CONFIG_SYS_I2C_EEPROM_ADDR_LEN 1
>>> #endif
>>>
>>> +#ifndef CONFIG_SYS_I2C_EEPROM_BUS
>>> +#define CONFIG_SYS_I2C_EEPROM_BUS 0
>>> +#endif
>>> +
>>> #define EEPROM_LAYOUT_VER_OFFSET 44
>>> #define BOARD_SERIAL_OFFSET 20
>>> #define BOARD_SERIAL_OFFSET_LEGACY 8
>>>
>
> a 'git grep CONFIG_SYS_I2C_EEPROM_BUS' shows that all values for
> CONFIG_SYS_I2C_EEPROM_BUS are set in include/configs/*.h.
>
> Therefore I would prefer that the temporary fix be in
> include/configs/trimslice.h header file too.
>
Given that trimslice does not use the eeprom code, I feel that
it's cleaner to not populate its config file with irrelevant
defines. It's also consistent with the way CONFIG_SYS_I2C_EEPROM_ADDR
and CONFIG_SYS_I2C_EEPROM_ADDR_LEN are handled.
--
Regards,
Nikita Kiryanov
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] compulab: eeprom: add default eeprom bus
2014-09-18 13:21 ` Nikita Kiryanov
@ 2014-09-18 20:35 ` Albert ARIBAUD
2014-10-08 12:03 ` Nikita Kiryanov
0 siblings, 1 reply; 7+ messages in thread
From: Albert ARIBAUD @ 2014-09-18 20:35 UTC (permalink / raw)
To: u-boot
Hi Nikita,
On Thu, 18 Sep 2014 16:21:07 +0300, Nikita Kiryanov
<nikita@compulab.co.il> wrote:
> Hi ALbert,
>
> On 18/09/14 15:26, Albert ARIBAUD wrote:
> > Hi Igor,
> >
> > On Wed, 17 Sep 2014 17:18:49 +0300, Igor Grinberg
> > <grinberg@compulab.co.il> wrote:
> >
> >> On 09/17/14 15:59, Nikita Kiryanov wrote:
> >>> Add default eeprom bus setting.
> >>> This addresses the trimslice compile error that was introduced
> >>> with the addition of this setting.
> >>>
> >>> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> >>> Cc: Igor Grinberg <grinberg@compulab.co.il>
> >>> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
> >>
> >> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
> >>
> >> Albert, this should be a temporary fix to not break the trimslice support.
> >> We intend to rework this while switching Kconfig for all boards.
> >>
> >> Thanks!
> >>
> >>> ---
> >>> board/compulab/common/eeprom.c | 4 ++++
> >>> 1 file changed, 4 insertions(+)
> >>>
> >>> diff --git a/board/compulab/common/eeprom.c b/board/compulab/common/eeprom.c
> >>> index 85442cd..2df3ada 100644
> >>> --- a/board/compulab/common/eeprom.c
> >>> +++ b/board/compulab/common/eeprom.c
> >>> @@ -15,6 +15,10 @@
> >>> # define CONFIG_SYS_I2C_EEPROM_ADDR_LEN 1
> >>> #endif
> >>>
> >>> +#ifndef CONFIG_SYS_I2C_EEPROM_BUS
> >>> +#define CONFIG_SYS_I2C_EEPROM_BUS 0
> >>> +#endif
> >>> +
> >>> #define EEPROM_LAYOUT_VER_OFFSET 44
> >>> #define BOARD_SERIAL_OFFSET 20
> >>> #define BOARD_SERIAL_OFFSET_LEGACY 8
> >>>
> >
> > a 'git grep CONFIG_SYS_I2C_EEPROM_BUS' shows that all values for
> > CONFIG_SYS_I2C_EEPROM_BUS are set in include/configs/*.h.
> >
> > Therefore I would prefer that the temporary fix be in
> > include/configs/trimslice.h header file too.
> >
>
> Given that trimslice does not use the eeprom code, I feel that
> it's cleaner to not populate its config file with irrelevant
> defines. It's also consistent with the way CONFIG_SYS_I2C_EEPROM_ADDR
> and CONFIG_SYS_I2C_EEPROM_ADDR_LEN are handled.
Makes sense enough.
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] compulab: eeprom: add default eeprom bus
2014-09-18 20:35 ` Albert ARIBAUD
@ 2014-10-08 12:03 ` Nikita Kiryanov
0 siblings, 0 replies; 7+ messages in thread
From: Nikita Kiryanov @ 2014-10-08 12:03 UTC (permalink / raw)
To: u-boot
Gentle ping.
On 18/09/14 23:35, Albert ARIBAUD wrote:
> Hi Nikita,
>
> On Thu, 18 Sep 2014 16:21:07 +0300, Nikita Kiryanov
> <nikita@compulab.co.il> wrote:
>
>> Hi ALbert,
>>
>> On 18/09/14 15:26, Albert ARIBAUD wrote:
>>> Hi Igor,
>>>
>>> On Wed, 17 Sep 2014 17:18:49 +0300, Igor Grinberg
>>> <grinberg@compulab.co.il> wrote:
>>>
>>>> On 09/17/14 15:59, Nikita Kiryanov wrote:
>>>>> Add default eeprom bus setting.
>>>>> This addresses the trimslice compile error that was introduced
>>>>> with the addition of this setting.
>>>>>
>>>>> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
>>>>> Cc: Igor Grinberg <grinberg@compulab.co.il>
>>>>> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
>>>>
>>>> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
>>>>
>>>> Albert, this should be a temporary fix to not break the trimslice support.
>>>> We intend to rework this while switching Kconfig for all boards.
>>>>
>>>> Thanks!
>>>>
>>>>> ---
>>>>> board/compulab/common/eeprom.c | 4 ++++
>>>>> 1 file changed, 4 insertions(+)
>>>>>
>>>>> diff --git a/board/compulab/common/eeprom.c b/board/compulab/common/eeprom.c
>>>>> index 85442cd..2df3ada 100644
>>>>> --- a/board/compulab/common/eeprom.c
>>>>> +++ b/board/compulab/common/eeprom.c
>>>>> @@ -15,6 +15,10 @@
>>>>> # define CONFIG_SYS_I2C_EEPROM_ADDR_LEN 1
>>>>> #endif
>>>>>
>>>>> +#ifndef CONFIG_SYS_I2C_EEPROM_BUS
>>>>> +#define CONFIG_SYS_I2C_EEPROM_BUS 0
>>>>> +#endif
>>>>> +
>>>>> #define EEPROM_LAYOUT_VER_OFFSET 44
>>>>> #define BOARD_SERIAL_OFFSET 20
>>>>> #define BOARD_SERIAL_OFFSET_LEGACY 8
>>>>>
>>>
>>> a 'git grep CONFIG_SYS_I2C_EEPROM_BUS' shows that all values for
>>> CONFIG_SYS_I2C_EEPROM_BUS are set in include/configs/*.h.
>>>
>>> Therefore I would prefer that the temporary fix be in
>>> include/configs/trimslice.h header file too.
>>>
>>
>> Given that trimslice does not use the eeprom code, I feel that
>> it's cleaner to not populate its config file with irrelevant
>> defines. It's also consistent with the way CONFIG_SYS_I2C_EEPROM_ADDR
>> and CONFIG_SYS_I2C_EEPROM_ADDR_LEN are handled.
>
> Makes sense enough.
>
> Amicalement,
>
--
Regards,
Nikita Kiryanov
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] compulab: eeprom: add default eeprom bus
2014-09-17 12:59 [U-Boot] [PATCH] compulab: eeprom: add default eeprom bus Nikita Kiryanov
2014-09-17 14:18 ` Igor Grinberg
@ 2014-10-09 8:50 ` Albert ARIBAUD
1 sibling, 0 replies; 7+ messages in thread
From: Albert ARIBAUD @ 2014-10-09 8:50 UTC (permalink / raw)
To: u-boot
Hi Nikita,
On Wed, 17 Sep 2014 15:59:25 +0300, Nikita Kiryanov
<nikita@compulab.co.il> wrote:
> Add default eeprom bus setting.
> This addresses the trimslice compile error that was introduced
> with the addition of this setting.
>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> Cc: Igor Grinberg <grinberg@compulab.co.il>
> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
> ---
> board/compulab/common/eeprom.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/board/compulab/common/eeprom.c b/board/compulab/common/eeprom.c
> index 85442cd..2df3ada 100644
> --- a/board/compulab/common/eeprom.c
> +++ b/board/compulab/common/eeprom.c
> @@ -15,6 +15,10 @@
> # define CONFIG_SYS_I2C_EEPROM_ADDR_LEN 1
> #endif
>
> +#ifndef CONFIG_SYS_I2C_EEPROM_BUS
> +#define CONFIG_SYS_I2C_EEPROM_BUS 0
> +#endif
> +
> #define EEPROM_LAYOUT_VER_OFFSET 44
> #define BOARD_SERIAL_OFFSET 20
> #define BOARD_SERIAL_OFFSET_LEGACY 8
Applied to u-boot-arm/master, thanks!
Unclean builds now down from 6 to 5 (openrd_client openrd_ultimate
tricorder_flash openrd_base tricorder)
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-10-09 8:50 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-17 12:59 [U-Boot] [PATCH] compulab: eeprom: add default eeprom bus Nikita Kiryanov
2014-09-17 14:18 ` Igor Grinberg
2014-09-18 12:26 ` Albert ARIBAUD
2014-09-18 13:21 ` Nikita Kiryanov
2014-09-18 20:35 ` Albert ARIBAUD
2014-10-08 12:03 ` Nikita Kiryanov
2014-10-09 8:50 ` Albert ARIBAUD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).