From: Sean Cross <xobs@kosagi.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V5] ARM: mx6: Add support for Kosagi Novena
Date: Thu, 09 Oct 2014 13:32:20 +0800 [thread overview]
Message-ID: <54361DE4.50100@kosagi.com> (raw)
In-Reply-To: <201410090159.37725.marex@denx.de>
On 09/10/2014 07:59, Marek Vasut wrote:
> On Wednesday, October 08, 2014 at 05:35:44 PM, picmaster at mail.bg wrote:
>> Hi Sean,
> Hi all,
Hello
>
>> ----- ????? ?? Sean Cross (xobs at kosagi.com), ?? 08.10.2014 ? 10:47 -----
>>
>>> On 08/10/2014 05:55, Nikolay Dimitrov wrote:
>>>> Hi Marek,
>>>>
>>>> I'm marking only the critical issues that are left unfixed from
>>>> previous conversations, to speed-up the process a little bit.
>>>> I'll send later patches for the non-critical issues to spare you the
>>>> extra work (and I'm sure my constructive criticism is already boring
>>>>
>>>> :D ).
>>>>
>>>> On 10/06/2014 07:02 PM, Marek Vasut wrote:
>>>>> +#define NOVENA_USB_HUB_RESET IMX_GPIO_NR(7, 12)
>>>> ...
>>>>
>>>>> +/*
>>>>> + * USB
>>>>> + */
>>>>> +#ifdef CONFIG_USB_EHCI_MX6
>>>>> +int board_ehci_hcd_init(int port)
>>>>> +{
>>>>> + /* Reset USB hub */
>>>>> + if (port == 1) {
>>>>> + gpio_set_value(NOVENA_USB_HUB_RESET, 0);
>>>>> + mdelay(2);
>>>>> + gpio_set_value(NOVENA_USB_HUB_RESET, 1);
>>>>> + }
>>>>> + return 0;
>>>>> +}
>>>>> +#endif
>>>> As we previously discussed, this pin definition conflicts with
>>>> NOVENA_PCIE_POWER_ON_GPIO (GPIO7_IO12 is connected to PCIE_PWRON), so
>>>> by asserting it, you'll turn-off the wrong sub-system.
>>>>
>>>> Currently the USB hub is reset only by system reset (RESETBMCU
>>>> asserted by the PMIC). I don't see how the CPU can selectively reset
>>>> the USB hub via a GPIO, so it would be better to remove the reset code.
>>>>
>>>> @Sean - can you please confirm/reject this finding?
>> @Sean: Do you have any comments on USB hub reset stuff? Should we ditch
>> entirely the reset code, or should we modify it somehow to work properly?
> OK, so it's just this USB that remains, right ?
This is correct. There is no GPIO-based way to reset the hub.
Sean
next prev parent reply other threads:[~2014-10-09 5:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 16:02 [U-Boot] [PATCH V5] ARM: mx6: Add support for Kosagi Novena Marek Vasut
2014-10-07 9:52 ` Sean Cross
2014-10-07 10:05 ` Marek Vasut
2014-10-07 21:55 ` Nikolay Dimitrov
2014-10-08 7:47 ` Sean Cross
2014-10-08 15:35 ` picmaster at mail.bg
2014-10-08 23:59 ` Marek Vasut
2014-10-09 0:13 ` Nikolay Dimitrov
2014-10-09 0:28 ` Marek Vasut
2014-10-09 1:04 ` Nikolay Dimitrov
2014-10-09 23:13 ` Marek Vasut
2014-10-09 7:31 ` Stefano Babic
2014-10-09 14:08 ` Marek Vasut
2014-10-09 5:32 ` Sean Cross [this message]
2014-10-09 5:38 ` Sean Cross
2014-10-09 11:48 ` Nikolay Dimitrov
2014-10-08 23:59 ` Marek Vasut
2014-10-09 7:36 ` Stefano Babic
2014-10-09 14:08 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54361DE4.50100@kosagi.com \
--to=xobs@kosagi.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox