[U-Boot] [PATCH V6] ARM: mx6: Add support for Kosagi Novena

Nikolay Dimitrov
2014-10-11T06:39:48Z

Hi Marek,

On 10/11/2014 04:24 AM, Marek Vasut wrote:
> On Friday, October 10, 2014 at 03:39:08 AM, Nikolay Dimitrov wrote:
>> Hi Marek,
>>
>> The usual stuff follows :D.
>>
>> On 10/10/2014 02:22 AM, Marek Vasut wrote:
>>> +#define NOVENA_BUTTON_GPIO IMX_GPIO_NR(4, 14)
>>> +#define NOVENA_SD_WP IMX_GPIO_NR(1, 2)
>>> +#define NOVENA_SD_CD IMX_GPIO_NR(1, 4)
>>
>> NOVENA_BUTTON_GPIO is initialized as input in this source file, but the
>> NOVENA_SD_WP and NOVENA_SD_CD are not. They're initialized only in
>> novena_spl.c, and if you change the SPL configuration, they won't be
>> explicitly initialized.
>>
>> While by pure luck the iomuxc reset values are those of the GPIO pins, I
>> would vote for explicit initialization of WP & CD.
>>
>> And btw, it's cool that you added the WP pin, I totally missed this out
>> last time I was staring at the schematic.
>
> I disagree that doing the initialization of pinmux twice is necessary,
> the SPL will always run before the rest of the software, so it will do
> the pinmux init. If you mean GPIO direction, then that's done in V7.

I also agree that there's no need to pinmux twice. And yes, what I meant
was to set the WP/CD GPIOs pin directions, so thanks for fixing that.

Regards,
Nikolay