[U-Boot] [PATCH V6] ARM: mx6: Add support for Kosagi Novena

Marek Vasut
2014-10-11T01:24:24Z

On Friday, October 10, 2014 at 03:39:08 AM, Nikolay Dimitrov wrote:
> Hi Marek,
>
> The usual stuff follows :D.
>
> On 10/10/2014 02:22 AM, Marek Vasut wrote:
> > +#define NOVENA_BUTTON_GPIO IMX_GPIO_NR(4, 14)
> > +#define NOVENA_SD_WP IMX_GPIO_NR(1, 2)
> > +#define NOVENA_SD_CD IMX_GPIO_NR(1, 4)
>
> NOVENA_BUTTON_GPIO is initialized as input in this source file, but the
> NOVENA_SD_WP and NOVENA_SD_CD are not. They're initialized only in
> novena_spl.c, and if you change the SPL configuration, they won't be
> explicitly initialized.
>
> While by pure luck the iomuxc reset values are those of the GPIO pins, I
> would vote for explicit initialization of WP & CD.
>
> And btw, it's cool that you added the WP pin, I totally missed this out
> last time I was staring at the schematic.

I disagree that doing the initialization of pinmux twice is necessary,
the SPL will always run before the rest of the software, so it will do
the pinmux init. If you mean GPIO direction, then that's done in V7.

> > +/*
> > + * USB
> > + */
> > +#ifdef CONFIG_USB_EHCI_MX6
> > +static iomux_v3_cfg_t usb_pads[] = {
> > + MX6_PAD_GPIO_17__GPIO7_IO12 | MUX_PAD_CTRL(NO_PAD_CTRL),
> > +};
> > +
> > +static void novena_spl_setup_iomux_usb(void)
> > +{
> > + imx_iomux_v3_setup_multiple_pads(usb_pads, ARRAY_SIZE(usb_pads));
> > +}
> > +#else
> > +static void novena_spl_setup_iomux_usb(void) {}
> > +#endif
>
> The patch comments are saying this is gone :).

Only part of it then, thanks. The rest should be fixed.

btw. just curious, you're one of the novena backers ?

[...]

Best regards,
Marek Vasut