From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/5] sunxi: Turn MMC_SUNXI_SLOT_EXTRA into a proper Kconfig option
Date: Sun, 12 Oct 2014 10:32:03 +0200 [thread overview]
Message-ID: <543A3C83.6030409@redhat.com> (raw)
In-Reply-To: <1413042046.11505.29.camel@hellion.org.uk>
Hi,
On 10/11/2014 05:40 PM, Ian Campbell wrote:
> On Mon, 2014-10-06 at 19:57 +0200, Hans de Goede wrote:
>> Note we also drop the SPL check for initializing the 2nd mmc slot, the SPL
>> check is not necessary with Kconfig, because only options explicitly marked
>> as also being for the SPL get set during SPL builds.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> board/sunxi/Kconfig | 8 ++++++++
>> board/sunxi/board.c | 2 +-
>> 2 files changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
>> index 497b093..cb4a881 100644
>> --- a/board/sunxi/Kconfig
>> +++ b/board/sunxi/Kconfig
>> @@ -32,6 +32,14 @@ config USB_KEYBOARD
>> Say Y here to add support for using a USB keyboard (typically used
>> in combination with a graphical console on HDMI).
>>
>> +config MMC_SUNXI_SLOT_EXTRA
>> + int "mmc extra slot number"
>> + default -1
>> + ---help---
>> + sunxi builds always enable mmc0, some boards also have a sdcard slot
>> + or emmc on mmc2 or mmc3. Setting this to 2 or 3 will enable support
>> + for this.
>
> What happened to mmc1?
When writing this I was under the assumption that nothing was actually using
mmc1, I will fix the help text.
>
> Regardless:
>
> Acked-by: Ian Campbell <ijc@hellion.org.uk>
Regards,
Hans
next prev parent reply other threads:[~2014-10-12 8:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 17:57 [U-Boot] [PATCH v2 0/5] sunxi: Enable second sdcard slot found on some boards Hans de Goede
2014-10-06 17:57 ` [U-Boot] [PATCH v2 1/5] sunxi: Add mmc card-detect functionality Hans de Goede
2014-10-11 15:39 ` Ian Campbell
2014-10-12 8:30 ` Hans de Goede
2014-10-06 17:57 ` [U-Boot] [PATCH v2 2/5] sunxi: Turn MMC_SUNXI_SLOT_EXTRA into a proper Kconfig option Hans de Goede
2014-10-11 15:40 ` Ian Campbell
2014-10-12 8:32 ` Hans de Goede [this message]
2014-10-06 17:57 ` [U-Boot] [PATCH v2 3/5] sunxi: When we've both mmc0 and mmc2, detect from which one we're booting Hans de Goede
2014-10-11 15:43 ` Ian Campbell
2014-10-12 9:20 ` Hans de Goede
2014-10-06 17:57 ` [U-Boot] [PATCH v2 4/5] sunxi: Use PG3 - PG8 as io-pins for mmc1 Hans de Goede
2014-10-11 15:44 ` Ian Campbell
2014-10-06 17:57 ` [U-Boot] [PATCH v2 5/5] sunxi: Enable second sdcard slot found on some boards Hans de Goede
2014-10-11 15:47 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543A3C83.6030409@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox