From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] New discussion proposal for u-boot summit: "switch malloc to succeed or die model, as glib does"
Date: Sun, 12 Oct 2014 10:42:28 +0200 [thread overview]
Message-ID: <543A3EF4.9050304@redhat.com> (raw)
Hi All,
Sorry for the poor timing in bringing this up, but this just
came up when discussing the review of some sunxi patches.
Ian asked me to add error handling for mmc_create failing,
which, if used properly, only ever fails if calloc fails.
This made me thinking that we should switch u-boot to the
glib memory alloc failure handling model, which is put a
die() / abort() inside the low level malloc routines when
they fail.
The reasoning is that if malloc fails, you're typically looking
at a fatal error anyways, and this will allow removing error
handling from a lot of higher level users, reducing code, and
removing a lot of code paths which are in essence unused and
as such also very much untested.
I guess there may be some special cases where we don't want
the malloc_or_die behavior I'm advocating for, for those
we could introduce a malloc_unchecked function.
Detlev any chance you could squeeze this into the schedule
somewhere?
Regards,
Hans
next reply other threads:[~2014-10-12 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 8:42 Hans de Goede [this message]
2014-10-12 8:49 ` [U-Boot] New discussion proposal for u-boot summit: "switch malloc to succeed or die model, as glib does" Hans de Goede
2014-10-12 10:40 ` Detlev Zundel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543A3EF4.9050304@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox