[U-Boot] [PATCH v2 2/5] sunxi: Turn MMC_SUNXI_SLOT_EXTRA into a proper Kconfig option

Hans de Goede
2014-10-12T08:32:03Z

Hi,

On 10/11/2014 05:40 PM, Ian Campbell wrote:
> On Mon, 2014-10-06 at 19:57 +0200, Hans de Goede wrote:
>> Note we also drop the SPL check for initializing the 2nd mmc slot, the SPL
>> check is not necessary with Kconfig, because only options explicitly marked
>> as also being for the SPL get set during SPL builds.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> board/sunxi/Kconfig | 8 ++++++++
>> board/sunxi/board.c | 2 +-
>> 2 files changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
>> index 497b093..cb4a881 100644
>> --- a/board/sunxi/Kconfig
>> +++ b/board/sunxi/Kconfig
>> @@ -32,6 +32,14 @@ config USB_KEYBOARD
>> Say Y here to add support for using a USB keyboard (typically used
>> in combination with a graphical console on HDMI).
>>
>> +config MMC_SUNXI_SLOT_EXTRA
>> + int "mmc extra slot number"
>> + default -1
>> + ---help---
>> + sunxi builds always enable mmc0, some boards also have a sdcard slot
>> + or emmc on mmc2 or mmc3. Setting this to 2 or 3 will enable support
>> + for this.
>
> What happened to mmc1?

When writing this I was under the assumption that nothing was actually using
mmc1, I will fix the help text.

>
> Regardless:
>
> Acked-by: Ian Campbell <ijc@hellion.org.uk>

Regards,

Hans