[U-Boot] [PATCH] Revert "common, env: Fix support for environment in i2c eeprom"

Matthias Fuchs
2014-10-23T15:29:51Z

Hi Valentin,

On 10/14/2014 04:21 PM, Valentin Longchamp wrote:
> Hi Matthias,
>
> On 10/14/2014 02:32 PM, Matthias Fuchs wrote:
>> Hi Valentin,
>>
>> my patch fixed environment from i2c eeprom. I am not sure on which board
>> I ran into that trouble. Probably PMC440. So reverting my former patch
>> will break environment in i2c eeprom again on many boards.
>
> Good that you have answered to patch. I run into that trouble on our Keymile
> boards that have the environment in the EEPROM. On our boards, the environment
> eeprom works with or without your patch. However, with your patch, I cannot
> directly access ANY eeprom which is not on the CONFIG_I2C_ENV_EEPROM_BUS bus.
>
>>
>> But perhaps there's a better way to fix that.
>
> I think that the proposal that Holger made to actually define
> CONFIG_I2C_ENV_EEPROM_BUS for your boards is what I would try first.
I reverted my former patch and switched towards
CONFIG_I2C_ENV_EEPROM_BUS. This works fine for me. I will post a patch soon.

So

Acked-by: Matthias Fuchs <matthias.fuchs@esd.eu>