* [U-Boot] [PATCH] aboot: fix block addressing for don't care chunk type
@ 2014-10-16 3:19 Rob Herring
2014-10-17 17:17 ` Steve Rae
2014-10-27 22:21 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2014-10-16 3:19 UTC (permalink / raw)
To: u-boot
From: Rob Herring <robh@kernel.org>
CHUNK_TYPE_DONT_CARE should skip over the specified number of blocks, but
currently fails to increment the device block address. This results in
filesystem images getting written incorrectly. Add the missing block
address incrementing.
Cc: Steve Rae <srae@broadcom.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
common/aboot.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/aboot.c b/common/aboot.c
index d5c464b..fba8e3e 100644
--- a/common/aboot.c
+++ b/common/aboot.c
@@ -208,6 +208,7 @@ void write_sparse_image(block_dev_desc_t *dev_desc,
break;
case CHUNK_TYPE_DONT_CARE:
+ blk += blkcnt;
total_blocks += chunk_header->chunk_sz;
break;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] aboot: fix block addressing for don't care chunk type
2014-10-16 3:19 [U-Boot] [PATCH] aboot: fix block addressing for don't care chunk type Rob Herring
@ 2014-10-17 17:17 ` Steve Rae
2014-10-27 22:21 ` [U-Boot] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Steve Rae @ 2014-10-17 17:17 UTC (permalink / raw)
To: u-boot
Hi Rob:
THANKS!
On 14-10-15 08:19 PM, Rob Herring wrote:
> From: Rob Herring <robh@kernel.org>
>
> CHUNK_TYPE_DONT_CARE should skip over the specified number of blocks, but
> currently fails to increment the device block address. This results in
> filesystem images getting written incorrectly. Add the missing block
> address incrementing.
>
> Cc: Steve Rae <srae@broadcom.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> common/aboot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/common/aboot.c b/common/aboot.c
> index d5c464b..fba8e3e 100644
> --- a/common/aboot.c
> +++ b/common/aboot.c
> @@ -208,6 +208,7 @@ void write_sparse_image(block_dev_desc_t *dev_desc,
> break;
>
> case CHUNK_TYPE_DONT_CARE:
> + blk += blkcnt;
> total_blocks += chunk_header->chunk_sz;
> break;
>
>
Reviewed-by: Steve Rae <srae@broadcom.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] aboot: fix block addressing for don't care chunk type
2014-10-16 3:19 [U-Boot] [PATCH] aboot: fix block addressing for don't care chunk type Rob Herring
2014-10-17 17:17 ` Steve Rae
@ 2014-10-27 22:21 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2014-10-27 22:21 UTC (permalink / raw)
To: u-boot
On Thu, Oct 16, 2014 at 11:19:36AM +0800, Rob Herring wrote:
> From: Rob Herring <robh@kernel.org>
>
> CHUNK_TYPE_DONT_CARE should skip over the specified number of blocks, but
> currently fails to increment the device block address. This results in
> filesystem images getting written incorrectly. Add the missing block
> address incrementing.
>
> Cc: Steve Rae <srae@broadcom.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Steve Rae <srae@broadcom.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141027/9d47f95e/attachment.pgp>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-27 22:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-16 3:19 [U-Boot] [PATCH] aboot: fix block addressing for don't care chunk type Rob Herring
2014-10-17 17:17 ` Steve Rae
2014-10-27 22:21 ` [U-Boot] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox