From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v9 04/12] dm: exynos: dts: Adjust device tree files for U-Boot
Date: Mon, 20 Oct 2014 16:55:38 +0200 [thread overview]
Message-ID: <5445226A.8070409@samsung.com> (raw)
In-Reply-To: <1413362282-25451-5-git-send-email-sjg@chromium.org>
Hello Simon,
On 10/15/2014 10:37 AM, Simon Glass wrote:
> The pinctrl bindings used by Linux are an incomplete description of the
> hardware. It is possible in most cases to determine the register address
> of each, but not in all cases. By adding an additional property we can
> fix this, and avoid adding a table to U-Boot for every single Exynos
> SOC.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v9: None
> Changes in v8:
> - Add missing special case reg property for exynos5420 GPX0
>
> Changes in v7: None
> Changes in v6:
> - Move U-Boot changes into their own file
> - Use exynos54xx everywhere instead of exynos5420
>
> Changes in v5: None
> Changes in v4: None
>
> arch/arm/dts/exynos4210-pinctrl-uboot.dtsi | 27 ++++++++++++++++++
> arch/arm/dts/exynos4210-pinctrl.dtsi | 2 ++
> arch/arm/dts/exynos4x12-pinctrl-uboot.dtsi | 46 ++++++++++++++++++++++++++++++
> arch/arm/dts/exynos4x12-pinctrl.dtsi | 2 ++
> arch/arm/dts/exynos5250-pinctrl-uboot.dtsi | 40 ++++++++++++++++++++++++++
> arch/arm/dts/exynos5250-pinctrl.dtsi | 2 ++
> arch/arm/dts/exynos54xx-pinctrl-uboot.dtsi | 40 ++++++++++++++++++++++++++
> arch/arm/dts/exynos54xx-pinctrl.dtsi | 2 ++
> arch/arm/dts/exynos54xx.dtsi | 1 +
> 9 files changed, 162 insertions(+)
> create mode 100644 arch/arm/dts/exynos4210-pinctrl-uboot.dtsi
> create mode 100644 arch/arm/dts/exynos4x12-pinctrl-uboot.dtsi
> create mode 100644 arch/arm/dts/exynos5250-pinctrl-uboot.dtsi
> create mode 100644 arch/arm/dts/exynos54xx-pinctrl-uboot.dtsi
>
... snip ...
> diff --git a/arch/arm/dts/exynos4210-pinctrl.dtsi b/arch/arm/dts/exynos4210-pinctrl.dtsi
> index bda17f7..87f162b 100644
> --- a/arch/arm/dts/exynos4210-pinctrl.dtsi
> +++ b/arch/arm/dts/exynos4210-pinctrl.dtsi
> @@ -14,6 +14,8 @@
> * published by the Free Software Foundation.
> */
>
> +#include "exynos4210-pinctrl-uboot.dtsi"
> +
> / {
> pinctrl at 11400000 {
> gpa0: gpa0 {
> diff --git a/arch/arm/dts/exynos4x12-pinctrl-uboot.dtsi b/arch/arm/dts/exynos4x12-pinctrl-uboot.dtsi
> new file mode 100644
> index 0000000..c02796d
> --- /dev/null
> +++ b/arch/arm/dts/exynos4x12-pinctrl-uboot.dtsi
> @@ -0,0 +1,46 @@
> +/*
> + * U-Boot additions to enable a generic Exynos GPIO driver
> + *
> + * Copyright (c) 2014 Google, Inc
> + */
> +
> +/{
> + pinctrl_0: pinctrl at 11400000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
The first issue with Exynos GPIO driver starts here. If you put pinctrl*
node data in a separated file, then the order of nodes in dtb is
changed. So for the pinctrl 0, the first subnode is gpf0, instead of
gpa0. And the same is for other pinctrls.
This means that function gpio_exynos_bind(), which expects proper
subnodes order assign wrong base addresses to some GPIO pins.
Move "reg" properties into arch/arm/dts/exynos4x12-pinctrl.dtsi fixes
this issue. But in this case, the file *-pinctrl-uboot.dtsi is quite
useless - since the cells size can be moved to pinctrl.dtsi too.
This probably will touch all *pinctrl-uboot.dtsi files.
next prev parent reply other threads:[~2014-10-20 14:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 8:37 [U-Boot] [PATCH v9 0/12] Enable driver model for GPIOs on Tegra and Exynos Simon Glass
2014-10-15 8:37 ` [U-Boot] [PATCH v9 01/12] dm: exynos: dts: Convert /include/ to #include Simon Glass
2014-10-15 8:37 ` [U-Boot] [PATCH v9 02/12] dm: exynos: Bring in pinctrl dts files from Linux kernel Simon Glass
2014-10-15 8:37 ` [U-Boot] [PATCH v9 03/12] dm: exynos: dts: Remove unused pinctrl information to save space Simon Glass
2014-10-15 8:37 ` [U-Boot] [PATCH v9 04/12] dm: exynos: dts: Adjust device tree files for U-Boot Simon Glass
2014-10-20 14:55 ` Przemyslaw Marczak [this message]
2014-10-20 15:29 ` Simon Glass
2014-10-15 8:37 ` [U-Boot] [PATCH v9 05/12] dm: exynos: Add pinctrl settings for smdkc100 Simon Glass
2014-10-15 8:37 ` [U-Boot] [PATCH v9 06/12] dm: exynos: Add pinctrl settings for s5p_goni Simon Glass
2014-10-15 8:37 ` [U-Boot] [PATCH v9 07/12] dm: exynos: Move smdkc100 to generic board Simon Glass
2014-10-15 8:37 ` [U-Boot] [PATCH v9 08/12] dm: exynos: Move s5p_goni " Simon Glass
2014-10-15 8:37 ` [U-Boot] [PATCH v9 09/12] dm: exynos: Tidy up GPIO headers Simon Glass
2014-10-15 8:38 ` [U-Boot] [PATCH v9 10/12] dm: exynos: Tidy up GPIO defines Simon Glass
2014-10-15 8:38 ` [U-Boot] [PATCH v9 11/12] dm: exynos: Make sure that GPIOs are requested Simon Glass
2014-10-15 8:38 ` [U-Boot] [PATCH v9 12/12] dm: exynos: gpio: Convert to driver model Simon Glass
2014-10-20 14:55 ` Przemyslaw Marczak
2014-10-20 15:31 ` Simon Glass
2014-10-20 15:53 ` Przemyslaw Marczak
2014-10-20 16:06 ` Przemyslaw Marczak
2014-10-20 17:26 ` Simon Glass
2014-10-20 14:54 ` [U-Boot] [PATCH v9 0/12] Enable driver model for GPIOs on Tegra and Exynos Przemyslaw Marczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5445226A.8070409@samsung.com \
--to=p.marczak@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox