From: Andrew Ruder <andrew.ruder@elecsyscorp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3 V2] dm9000: rework dm9000 to support multiple devices
Date: Mon, 20 Oct 2014 20:16:59 +0000 [thread overview]
Message-ID: <54456DBB.9030903@elecsyscorp.com> (raw)
In-Reply-To: <20141020200016.GS25506@bill-the-cat>
On 10/20/2014 03:00 PM, Tom Rini wrote:
> So, on new platforms we call dm9000_initialize with the right IO/DATA
> locations for the given device, yes? I think I'd rather update everyone
> else to call things the right and new way, rather than work-around
> supporting both.
The expectation is that new platforms would move over to
dm9000_initialize_ex(), dm9000_initialize() just being a shim to use
what used to be #define'd in the board config.h for backwards
compatibility with older boards.
There's really 3 options that I fought with:
1.) Change dm9000_initialize() to dm9000_initialize(x, y, z). PATCH #3
then also includes changes to all of the various boards.
2.) Add dm9000_initialize_ex(x, y, z), make dm9000_initialize() call
dm9000_initiailize_ex(x, y, z). No boards need to change. This is what
I chose.
3.) Hybrid approach, do #2, make another patch (#4) that moves
everything over to dm9000_initialize_ex(x, y, z) while renaming it to
dm9000_initialize(x, y, z). Seems more round-about than #1 with the
same end-result, but sometimes I feel like it is a little easier to
review the meat of this change (#3) without it also dealing with tons of
board churn.
Thoughts?
- Andy
next prev parent reply other threads:[~2014-10-20 20:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 14:59 [U-Boot] [PATCH 0/3] DM9000 support for multiple interfaces Andrew Ruder
2014-10-20 14:59 ` [U-Boot] [PATCH 1/3] dm9000: mark dump_regs() function as unused Andrew Ruder
2014-10-20 19:10 ` Tom Rini
2014-10-20 14:59 ` [U-Boot] [PATCH 2/3] dm9000: Add struct eth_device * to SROM functions Andrew Ruder
2014-10-20 15:22 ` Stefano Babic
2014-10-20 19:17 ` Tom Rini
2014-10-20 19:39 ` Andrew Ruder
2014-10-20 14:59 ` [U-Boot] [PATCH 3/3] dm9000: rework dm9000 to support multiple devices Andrew Ruder
2014-10-20 15:45 ` Andrew Ruder
2014-10-20 18:11 ` [U-Boot] [PATCH 3/3 V2] " Andrew Ruder
2014-10-20 20:00 ` Tom Rini
2014-10-20 20:16 ` Andrew Ruder [this message]
2014-10-20 23:47 ` Tom Rini
2015-08-11 17:58 ` Joe Hershberger
2015-08-11 21:10 ` Andrew Ruder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54456DBB.9030903@elecsyscorp.com \
--to=andrew.ruder@elecsyscorp.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox