public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] kbuild: clear VENDOR variable to fix build error on tcsh
Date: Tue, 21 Oct 2014 09:58:41 +0200	[thread overview]
Message-ID: <54461231.9030100@myspectrum.nl> (raw)
In-Reply-To: <1413865112-7832-1-git-send-email-yamada.m@jp.panasonic.com>

Thanks Masahiro,

On 21-10-14 06:18, Masahiro Yamada wrote:
> Since the environment "VENDOR" is set in tcsh, it must be cleared in our
> makefile.  Otherwise, boards without CONFIG_SYS_VENDOR fail to build:
>
>    > make CROSS_COMPILE=arm-linux-gnueabi- wandboard_quad_defconfig all
>      [ snip ]
>      AR      arch/arm/lib/lib.a
>      CC      arch/arm/lib/eabi_compat.o
>    scripts/Makefile.build:55: /home/foo/u-boot/board/unknown/wandboard/ \
>    Makefile: No such file or directory
>    make[2]: *** No rule to make target `/home/foo/u-boot/board/unknown/ \
>    wandboard/Makefile'.  Stop.
>    make[1]: *** [board/unknown/wandboard] Error 2
>    make: *** [__build_one_by_one] Error 2
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Reported-by: Tom Everett <tom@khubla.com>
> Reported-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> ---
>
>   config.mk | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/config.mk b/config.mk
> index 2157537..00805bd 100644
> --- a/config.mk
> +++ b/config.mk
> @@ -18,6 +18,8 @@ PLATFORM_LDFLAGS :=
>   LDFLAGS :=
>   LDFLAGS_FINAL :=
>   OBJCOPYFLAGS :=
> +# clear VENDOR for tcsh
> +VENDOR :=
>   #########################################################################
>   
>   ARCH := $(CONFIG_SYS_ARCH:"%"=%)

ah, understood now. Make does suck in the complete env as make
variables but assignments will overwrite the value. make VENDOR=bla
would ignore the assignment unless overridden. The ifneq below
causes the VENDOR never to be assigned in some cases and hence
the value from the original env is used. So

Acked-by: Jeroen Hofstee <jeroen@myspectrum.nl>
Tested-by: Jeroen Hofstee <jeroen@myspectrum.nl>

Regards,
Jeroen

  reply	other threads:[~2014-10-21  7:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-21  4:18 [U-Boot] [PATCH] kbuild: clear VENDOR variable to fix build error on tcsh Masahiro Yamada
2014-10-21  7:58 ` Jeroen Hofstee [this message]
2014-10-21 13:20 ` Tom Rini
2014-10-21 13:41   ` Masahiro YAMADA
2014-10-21 16:13     ` Tom Rini
2014-10-21 16:29       ` Tom Rini
2014-10-23 20:35 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54461231.9030100@myspectrum.nl \
    --to=jeroen@myspectrum.nl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox