From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeroen Hofstee Date: Tue, 21 Oct 2014 09:58:41 +0200 Subject: [U-Boot] [PATCH] kbuild: clear VENDOR variable to fix build error on tcsh In-Reply-To: <1413865112-7832-1-git-send-email-yamada.m@jp.panasonic.com> References: <1413865112-7832-1-git-send-email-yamada.m@jp.panasonic.com> Message-ID: <54461231.9030100@myspectrum.nl> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Thanks Masahiro, On 21-10-14 06:18, Masahiro Yamada wrote: > Since the environment "VENDOR" is set in tcsh, it must be cleared in our > makefile. Otherwise, boards without CONFIG_SYS_VENDOR fail to build: > > > make CROSS_COMPILE=arm-linux-gnueabi- wandboard_quad_defconfig all > [ snip ] > AR arch/arm/lib/lib.a > CC arch/arm/lib/eabi_compat.o > scripts/Makefile.build:55: /home/foo/u-boot/board/unknown/wandboard/ \ > Makefile: No such file or directory > make[2]: *** No rule to make target `/home/foo/u-boot/board/unknown/ \ > wandboard/Makefile'. Stop. > make[1]: *** [board/unknown/wandboard] Error 2 > make: *** [__build_one_by_one] Error 2 > > Signed-off-by: Masahiro Yamada > Reported-by: Tom Everett > Reported-by: Jeroen Hofstee > --- > > config.mk | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/config.mk b/config.mk > index 2157537..00805bd 100644 > --- a/config.mk > +++ b/config.mk > @@ -18,6 +18,8 @@ PLATFORM_LDFLAGS := > LDFLAGS := > LDFLAGS_FINAL := > OBJCOPYFLAGS := > +# clear VENDOR for tcsh > +VENDOR := > ######################################################################### > > ARCH := $(CONFIG_SYS_ARCH:"%"=%) ah, understood now. Make does suck in the complete env as make variables but assignments will overwrite the value. make VENDOR=bla would ignore the assignment unless overridden. The ifneq below causes the VENDOR never to be assigned in some cases and hence the value from the original env is used. So Acked-by: Jeroen Hofstee Tested-by: Jeroen Hofstee Regards, Jeroen