* [U-Boot] [PATCH] kbuild: clear VENDOR variable to fix build error on tcsh
@ 2014-10-21 4:18 Masahiro Yamada
2014-10-21 7:58 ` Jeroen Hofstee
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Masahiro Yamada @ 2014-10-21 4:18 UTC (permalink / raw)
To: u-boot
Since the environment "VENDOR" is set in tcsh, it must be cleared in our
makefile. Otherwise, boards without CONFIG_SYS_VENDOR fail to build:
> make CROSS_COMPILE=arm-linux-gnueabi- wandboard_quad_defconfig all
[ snip ]
AR arch/arm/lib/lib.a
CC arch/arm/lib/eabi_compat.o
scripts/Makefile.build:55: /home/foo/u-boot/board/unknown/wandboard/ \
Makefile: No such file or directory
make[2]: *** No rule to make target `/home/foo/u-boot/board/unknown/ \
wandboard/Makefile'. Stop.
make[1]: *** [board/unknown/wandboard] Error 2
make: *** [__build_one_by_one] Error 2
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Reported-by: Tom Everett <tom@khubla.com>
Reported-by: Jeroen Hofstee <jeroen@myspectrum.nl>
---
config.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/config.mk b/config.mk
index 2157537..00805bd 100644
--- a/config.mk
+++ b/config.mk
@@ -18,6 +18,8 @@ PLATFORM_LDFLAGS :=
LDFLAGS :=
LDFLAGS_FINAL :=
OBJCOPYFLAGS :=
+# clear VENDOR for tcsh
+VENDOR :=
#########################################################################
ARCH := $(CONFIG_SYS_ARCH:"%"=%)
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [U-Boot] [PATCH] kbuild: clear VENDOR variable to fix build error on tcsh
2014-10-21 4:18 [U-Boot] [PATCH] kbuild: clear VENDOR variable to fix build error on tcsh Masahiro Yamada
@ 2014-10-21 7:58 ` Jeroen Hofstee
2014-10-21 13:20 ` Tom Rini
2014-10-23 20:35 ` Tom Rini
2 siblings, 0 replies; 7+ messages in thread
From: Jeroen Hofstee @ 2014-10-21 7:58 UTC (permalink / raw)
To: u-boot
Thanks Masahiro,
On 21-10-14 06:18, Masahiro Yamada wrote:
> Since the environment "VENDOR" is set in tcsh, it must be cleared in our
> makefile. Otherwise, boards without CONFIG_SYS_VENDOR fail to build:
>
> > make CROSS_COMPILE=arm-linux-gnueabi- wandboard_quad_defconfig all
> [ snip ]
> AR arch/arm/lib/lib.a
> CC arch/arm/lib/eabi_compat.o
> scripts/Makefile.build:55: /home/foo/u-boot/board/unknown/wandboard/ \
> Makefile: No such file or directory
> make[2]: *** No rule to make target `/home/foo/u-boot/board/unknown/ \
> wandboard/Makefile'. Stop.
> make[1]: *** [board/unknown/wandboard] Error 2
> make: *** [__build_one_by_one] Error 2
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Reported-by: Tom Everett <tom@khubla.com>
> Reported-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> ---
>
> config.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/config.mk b/config.mk
> index 2157537..00805bd 100644
> --- a/config.mk
> +++ b/config.mk
> @@ -18,6 +18,8 @@ PLATFORM_LDFLAGS :=
> LDFLAGS :=
> LDFLAGS_FINAL :=
> OBJCOPYFLAGS :=
> +# clear VENDOR for tcsh
> +VENDOR :=
> #########################################################################
>
> ARCH := $(CONFIG_SYS_ARCH:"%"=%)
ah, understood now. Make does suck in the complete env as make
variables but assignments will overwrite the value. make VENDOR=bla
would ignore the assignment unless overridden. The ifneq below
causes the VENDOR never to be assigned in some cases and hence
the value from the original env is used. So
Acked-by: Jeroen Hofstee <jeroen@myspectrum.nl>
Tested-by: Jeroen Hofstee <jeroen@myspectrum.nl>
Regards,
Jeroen
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] kbuild: clear VENDOR variable to fix build error on tcsh
2014-10-21 4:18 [U-Boot] [PATCH] kbuild: clear VENDOR variable to fix build error on tcsh Masahiro Yamada
2014-10-21 7:58 ` Jeroen Hofstee
@ 2014-10-21 13:20 ` Tom Rini
2014-10-21 13:41 ` Masahiro YAMADA
2014-10-23 20:35 ` Tom Rini
2 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2014-10-21 13:20 UTC (permalink / raw)
To: u-boot
On Tue, Oct 21, 2014 at 01:18:32PM +0900, Masahiro Yamada wrote:
> Since the environment "VENDOR" is set in tcsh, it must be cleared in our
> makefile. Otherwise, boards without CONFIG_SYS_VENDOR fail to build:
>
> > make CROSS_COMPILE=arm-linux-gnueabi- wandboard_quad_defconfig all
> [ snip ]
> AR arch/arm/lib/lib.a
> CC arch/arm/lib/eabi_compat.o
> scripts/Makefile.build:55: /home/foo/u-boot/board/unknown/wandboard/ \
> Makefile: No such file or directory
> make[2]: *** No rule to make target `/home/foo/u-boot/board/unknown/ \
> wandboard/Makefile'. Stop.
> make[1]: *** [board/unknown/wandboard] Error 2
> make: *** [__build_one_by_one] Error 2
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Reported-by: Tom Everett <tom@khubla.com>
> Reported-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> ---
>
> config.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/config.mk b/config.mk
> index 2157537..00805bd 100644
> --- a/config.mk
> +++ b/config.mk
> @@ -18,6 +18,8 @@ PLATFORM_LDFLAGS :=
> LDFLAGS :=
> LDFLAGS_FINAL :=
> OBJCOPYFLAGS :=
> +# clear VENDOR for tcsh
> +VENDOR :=
> #########################################################################
>
> ARCH := $(CONFIG_SYS_ARCH:"%"=%)
Are there other variables that might fit into this same category?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141021/046ffcd4/attachment.pgp>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] kbuild: clear VENDOR variable to fix build error on tcsh
2014-10-21 13:20 ` Tom Rini
@ 2014-10-21 13:41 ` Masahiro YAMADA
2014-10-21 16:13 ` Tom Rini
0 siblings, 1 reply; 7+ messages in thread
From: Masahiro YAMADA @ 2014-10-21 13:41 UTC (permalink / raw)
To: u-boot
Hi Tom,
2014-10-21 22:20 GMT+09:00 Tom Rini <trini@ti.com>:
>> diff --git a/config.mk b/config.mk
>> index 2157537..00805bd 100644
>> --- a/config.mk
>> +++ b/config.mk
>> @@ -18,6 +18,8 @@ PLATFORM_LDFLAGS :=
>> LDFLAGS :=
>> LDFLAGS_FINAL :=
>> OBJCOPYFLAGS :=
>> +# clear VENDOR for tcsh
>> +VENDOR :=
>> #########################################################################
>>
>> ARCH := $(CONFIG_SYS_ARCH:"%"=%)
>
> Are there other variables that might fit into this same category?
>
I am not sure but probably only this one.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] kbuild: clear VENDOR variable to fix build error on tcsh
2014-10-21 13:41 ` Masahiro YAMADA
@ 2014-10-21 16:13 ` Tom Rini
2014-10-21 16:29 ` Tom Rini
0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2014-10-21 16:13 UTC (permalink / raw)
To: u-boot
On Tue, Oct 21, 2014 at 10:41:02PM +0900, Masahiro YAMADA wrote:
> Hi Tom,
>
> 2014-10-21 22:20 GMT+09:00 Tom Rini <trini@ti.com>:
> >> diff --git a/config.mk b/config.mk
> >> index 2157537..00805bd 100644
> >> --- a/config.mk
> >> +++ b/config.mk
> >> @@ -18,6 +18,8 @@ PLATFORM_LDFLAGS :=
> >> LDFLAGS :=
> >> LDFLAGS_FINAL :=
> >> OBJCOPYFLAGS :=
> >> +# clear VENDOR for tcsh
> >> +VENDOR :=
> >> #########################################################################
> >>
> >> ARCH := $(CONFIG_SYS_ARCH:"%"=%)
> >
> > Are there other variables that might fit into this same category?
> >
>
> I am not sure but probably only this one.
Nope, SOC is one too. I _think_ this might even somehow be related (or
at least I hope it is!) to the hard to trigger on normal machines race
condition multi-build problem. You can see SOC fail with am335x_evm.
I'm going to play a bit more and post a v2 of this, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141021/6707402f/attachment.pgp>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] kbuild: clear VENDOR variable to fix build error on tcsh
2014-10-21 16:13 ` Tom Rini
@ 2014-10-21 16:29 ` Tom Rini
0 siblings, 0 replies; 7+ messages in thread
From: Tom Rini @ 2014-10-21 16:29 UTC (permalink / raw)
To: u-boot
On Tue, Oct 21, 2014 at 12:13:23PM -0400, Tom Rini wrote:
> On Tue, Oct 21, 2014 at 10:41:02PM +0900, Masahiro YAMADA wrote:
> > Hi Tom,
> >
> > 2014-10-21 22:20 GMT+09:00 Tom Rini <trini@ti.com>:
> > >> diff --git a/config.mk b/config.mk
> > >> index 2157537..00805bd 100644
> > >> --- a/config.mk
> > >> +++ b/config.mk
> > >> @@ -18,6 +18,8 @@ PLATFORM_LDFLAGS :=
> > >> LDFLAGS :=
> > >> LDFLAGS_FINAL :=
> > >> OBJCOPYFLAGS :=
> > >> +# clear VENDOR for tcsh
> > >> +VENDOR :=
> > >> #########################################################################
> > >>
> > >> ARCH := $(CONFIG_SYS_ARCH:"%"=%)
> > >
> > > Are there other variables that might fit into this same category?
> > >
> >
> > I am not sure but probably only this one.
>
> Nope, SOC is one too. I _think_ this might even somehow be related (or
> at least I hope it is!) to the hard to trigger on normal machines race
> condition multi-build problem. You can see SOC fail with am335x_evm.
> I'm going to play a bit more and post a v2 of this, thanks!
I take it back, it was a problem with one of my wrapper scripts.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141021/1c493707/attachment.pgp>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] kbuild: clear VENDOR variable to fix build error on tcsh
2014-10-21 4:18 [U-Boot] [PATCH] kbuild: clear VENDOR variable to fix build error on tcsh Masahiro Yamada
2014-10-21 7:58 ` Jeroen Hofstee
2014-10-21 13:20 ` Tom Rini
@ 2014-10-23 20:35 ` Tom Rini
2 siblings, 0 replies; 7+ messages in thread
From: Tom Rini @ 2014-10-23 20:35 UTC (permalink / raw)
To: u-boot
On Tue, Oct 21, 2014 at 01:18:32PM +0900, Masahiro Yamada wrote:
> Since the environment "VENDOR" is set in tcsh, it must be cleared in our
> makefile. Otherwise, boards without CONFIG_SYS_VENDOR fail to build:
>
> > make CROSS_COMPILE=arm-linux-gnueabi- wandboard_quad_defconfig all
> [ snip ]
> AR arch/arm/lib/lib.a
> CC arch/arm/lib/eabi_compat.o
> scripts/Makefile.build:55: /home/foo/u-boot/board/unknown/wandboard/ \
> Makefile: No such file or directory
> make[2]: *** No rule to make target `/home/foo/u-boot/board/unknown/ \
> wandboard/Makefile'. Stop.
> make[1]: *** [board/unknown/wandboard] Error 2
> make: *** [__build_one_by_one] Error 2
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Reported-by: Tom Everett <tom@khubla.com>
> Reported-by: Jeroen Hofstee <jeroen@myspectrum.nl>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141023/b2321c90/attachment.pgp>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-10-23 20:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-21 4:18 [U-Boot] [PATCH] kbuild: clear VENDOR variable to fix build error on tcsh Masahiro Yamada
2014-10-21 7:58 ` Jeroen Hofstee
2014-10-21 13:20 ` Tom Rini
2014-10-21 13:41 ` Masahiro YAMADA
2014-10-21 16:13 ` Tom Rini
2014-10-21 16:29 ` Tom Rini
2014-10-23 20:35 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox