From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Thu, 23 Oct 2014 10:52:23 +0200 Subject: [U-Boot] [PATCH] sun7i: Set CONFIG_ARMV7_SEC_BY_DEFAULT when CONFIG_OLD_KERNEL_COMPAT is set In-Reply-To: <20141022192400.GG25506@bill-the-cat> References: <1413985523-19303-1-git-send-email-hdegoede@redhat.com> <20141022192400.GG25506@bill-the-cat> Message-ID: <5448C1C7.4070200@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, On 10/22/2014 09:24 PM, Tom Rini wrote: > On Wed, Oct 22, 2014 at 03:45:23PM +0200, Hans de Goede wrote: > >> Old kernels cannot handle booting in non-secure (hyp) mode, so when >> CONFIG_OLD_KERNEL_COMPAT is set, also set CONFIG_ARMV7_SEC_BY_DEFAULT. >> >> Note that whether to booting secure or non-secure can always be overriden >> using the bootm_boot_mode environment variable. > > This belongs in Kconfig. If you want to make it really optional all the > same, make modifying it depend on CONFIG_EXPERT too. I understand where your coming from, but the problem is that CONFIG_ARMV7_SEC_BY_DEFAULT as a Kconfig option should depend on CONFIG_ARMV7_VIRT or CONFIG_ARMV7_NONSEC, which depend on CONFIG_ARMV7_PSCI / CONFIG_ARMV7_PSCI_NR_CPUS and CONFIG_ARMV7_SECURE_BASE, all of which are currently set through include/configs/foo.h. I know that the plan is to move all of these to Kconfig eventually, but there still is a lot of figuring out how that exactly should be done, and as such I believe that it is best to set CONFIG_ARMV7_SEC_BY_DEFAULT the "old-fashioned" way for now. Regards, Hans