[U-Boot] [PATCH] sun7i: Set CONFIG_ARMV7_SEC_BY_DEFAULT when CONFIG_OLD_KERNEL_COMPAT is set

Hans de Goede
2014-10-23T08:52:23Z

Hi Tom,

On 10/22/2014 09:24 PM, Tom Rini wrote:
> On Wed, Oct 22, 2014 at 03:45:23PM +0200, Hans de Goede wrote:
>
>> Old kernels cannot handle booting in non-secure (hyp) mode, so when
>> CONFIG_OLD_KERNEL_COMPAT is set, also set CONFIG_ARMV7_SEC_BY_DEFAULT.
>>
>> Note that whether to booting secure or non-secure can always be overriden
>> using the bootm_boot_mode environment variable.
>
> This belongs in Kconfig. If you want to make it really optional all the
> same, make modifying it depend on CONFIG_EXPERT too.

I understand where your coming from, but the problem is that
CONFIG_ARMV7_SEC_BY_DEFAULT as a Kconfig option should depend on
CONFIG_ARMV7_VIRT or CONFIG_ARMV7_NONSEC, which depend on
CONFIG_ARMV7_PSCI / CONFIG_ARMV7_PSCI_NR_CPUS and
CONFIG_ARMV7_SECURE_BASE, all of which are currently set
through include/configs/foo.h.

I know that the plan is to move all of these to Kconfig eventually,
but there still is a lot of figuring out how that exactly should be
done, and as such I believe that it is best to set
CONFIG_ARMV7_SEC_BY_DEFAULT the "old-fashioned" way for now.

Regards,

Hans