[U-Boot] [PATCH] sun7i: Set CONFIG_ARMV7_SEC_BY_DEFAULT when CONFIG_OLD_KERNEL_COMPAT is set

Tom Rini
2014-10-23T13:10:10Z

On Thu, Oct 23, 2014 at 10:52:23AM +0200, Hans de Goede wrote:
> Hi Tom,
>
> On 10/22/2014 09:24 PM, Tom Rini wrote:
> > On Wed, Oct 22, 2014 at 03:45:23PM +0200, Hans de Goede wrote:
> >
> >> Old kernels cannot handle booting in non-secure (hyp) mode, so when
> >> CONFIG_OLD_KERNEL_COMPAT is set, also set CONFIG_ARMV7_SEC_BY_DEFAULT.
> >>
> >> Note that whether to booting secure or non-secure can always be overriden
> >> using the bootm_boot_mode environment variable.
> >
> > This belongs in Kconfig. If you want to make it really optional all the
> > same, make modifying it depend on CONFIG_EXPERT too.
>
> I understand where your coming from, but the problem is that
> CONFIG_ARMV7_SEC_BY_DEFAULT as a Kconfig option should depend on
> CONFIG_ARMV7_VIRT or CONFIG_ARMV7_NONSEC, which depend on
> CONFIG_ARMV7_PSCI / CONFIG_ARMV7_PSCI_NR_CPUS and
> CONFIG_ARMV7_SECURE_BASE, all of which are currently set
> through include/configs/foo.h.

True, but lets fix it. Ideally, we would have something to select
"ARMV7", but we don't yet, and I won't make that your pre-req. All of
the above options are only used by sunxi and arndale and vexpress right
now. Add arch/arm/cpu/armv7/Kconfig for the above ARMv7 options, source
it from arch/arm/Kconfig and make the contents be on if ARNDALE || CA15
|| SUNXI with a comment on needing to clean this up further once we have
more fine-grained selects on SoC features.

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141023/d4b4dc69/attachment.pgp>