public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sun7i: Set CONFIG_ARMV7_SEC_BY_DEFAULT when CONFIG_OLD_KERNEL_COMPAT is set
Date: Thu, 23 Oct 2014 10:52:55 +0200	[thread overview]
Message-ID: <5448C1E7.30500@redhat.com> (raw)
In-Reply-To: <1414004235.20604.74.camel@hellion.org.uk>

Hi,

On 10/22/2014 08:57 PM, Ian Campbell wrote:
> On Wed, 2014-10-22 at 15:45 +0200, Hans de Goede wrote:
>> Old kernels cannot handle booting in non-secure (hyp) mode, so when
>> CONFIG_OLD_KERNEL_COMPAT is set, also set CONFIG_ARMV7_SEC_BY_DEFAULT.
>>
>> Note that whether to booting secure or non-secure can always be overriden
> 
> nits: "boot" (not booting, or s/whether to/ perhaps) and "overridden"
> 
>> using the bootm_boot_mode environment variable.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>>  include/configs/sun7i.h | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/include/configs/sun7i.h b/include/configs/sun7i.h
>> index 966cbd8..4a864b2 100644
>> --- a/include/configs/sun7i.h
>> +++ b/include/configs/sun7i.h
>> @@ -35,6 +35,10 @@
>>  #define CONFIG_ARMV7_PSCI		1
>>  #define CONFIG_ARMV7_PSCI_NR_CPUS	2
>>  #define CONFIG_ARMV7_SECURE_BASE	SUNXI_SRAM_B_BASE
>> +#ifdef CONFIG_OLD_KERNEL_COMPAT
>> +#define CONFIG_ARMV7_SEC_BY_DEFAULT	1
>> +#endif
> 
> I think this would be better right after the NONSEC+VIRT defines just
> above the context here, since they are related.

Fixed in my personal tree, I'll do a v2 as soon as the Kconfig
question Tom raised is answered.

Regards,

Hans

  reply	other threads:[~2014-10-23  8:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22 13:45 [U-Boot] [PATCH] sun7i: Set CONFIG_ARMV7_SEC_BY_DEFAULT when CONFIG_OLD_KERNEL_COMPAT is set Hans de Goede
2014-10-22 18:57 ` Ian Campbell
2014-10-23  8:52   ` Hans de Goede [this message]
2014-10-22 19:24 ` Tom Rini
2014-10-23  8:52   ` Hans de Goede
2014-10-23 13:10     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5448C1E7.30500@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox