From: Matthias Fuchs <matthias.fuchs@esd.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "common, env: Fix support for environment in i2c eeprom"
Date: Thu, 23 Oct 2014 16:15:24 +0200 [thread overview]
Message-ID: <54490D7C.1070806@esd.eu> (raw)
In-Reply-To: <543D3169.4010505@keymile.com>
Hi Valentin,
On 10/14/2014 04:21 PM, Valentin Longchamp wrote:
> Hi Matthias,
>
> On 10/14/2014 02:32 PM, Matthias Fuchs wrote:
>> Hi Valentin,
>>
>> my patch fixed environment from i2c eeprom. I am not sure on which board
>> I ran into that trouble. Probably PMC440. So reverting my former patch
>> will break environment in i2c eeprom again on many boards.
>
> Good that you have answered to patch. I run into that trouble on our Keymile
> boards that have the environment in the EEPROM. On our boards, the environment
> eeprom works with or without your patch. However, with your patch, I cannot
> directly access ANY eeprom which is not on the CONFIG_I2C_ENV_EEPROM_BUS bus.
>
>>
>> But perhaps there's a better way to fix that.
>
> I think that the proposal that Holger made to actually define
> CONFIG_I2C_ENV_EEPROM_BUS for your boards is what I would try first.
I reverted my former patch and switchedd towards
CONFIG_I2C_ENV_EEPROM_BUS. This works fine for me.
So I ack your patch to revert mine :-)
Matthias
next prev parent reply other threads:[~2014-10-23 14:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 9:16 [U-Boot] [PATCH] Revert "common, env: Fix support for environment in i2c eeprom" Valentin Longchamp
2014-10-14 12:32 ` Matthias Fuchs
2014-10-14 13:01 ` Holger Brunck
2014-10-14 14:20 ` Matthias Fuchs
2014-10-14 14:21 ` Valentin Longchamp
2014-10-23 14:15 ` Matthias Fuchs [this message]
2014-10-23 15:11 ` Tom Rini
2014-10-23 15:29 ` Matthias Fuchs
2014-10-27 22:19 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54490D7C.1070806@esd.eu \
--to=matthias.fuchs@esd.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox