From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Fuchs Date: Thu, 23 Oct 2014 16:15:24 +0200 Subject: [U-Boot] [PATCH] Revert "common, env: Fix support for environment in i2c eeprom" In-Reply-To: <543D3169.4010505@keymile.com> References: <1413278193-28886-1-git-send-email-valentin.longchamp@keymile.com> <543D17D3.608@esd.eu> <543D3169.4010505@keymile.com> Message-ID: <54490D7C.1070806@esd.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Valentin, On 10/14/2014 04:21 PM, Valentin Longchamp wrote: > Hi Matthias, > > On 10/14/2014 02:32 PM, Matthias Fuchs wrote: >> Hi Valentin, >> >> my patch fixed environment from i2c eeprom. I am not sure on which board >> I ran into that trouble. Probably PMC440. So reverting my former patch >> will break environment in i2c eeprom again on many boards. > > Good that you have answered to patch. I run into that trouble on our Keymile > boards that have the environment in the EEPROM. On our boards, the environment > eeprom works with or without your patch. However, with your patch, I cannot > directly access ANY eeprom which is not on the CONFIG_I2C_ENV_EEPROM_BUS bus. > >> >> But perhaps there's a better way to fix that. > > I think that the proposal that Holger made to actually define > CONFIG_I2C_ENV_EEPROM_BUS for your boards is what I would try first. I reverted my former patch and switchedd towards CONFIG_I2C_ENV_EEPROM_BUS. This works fine for me. So I ack your patch to revert mine :-) Matthias