public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i2c: designware: Convert driver to multibus/multiadapter framework
Date: Fri, 24 Oct 2014 07:57:19 +0200	[thread overview]
Message-ID: <5449EA3F.4080900@denx.de> (raw)
In-Reply-To: <1414085138.3741.20.camel@abrodkin-8560l.internal.synopsys.com>

Hi Alexey,

On 23.10.2014 19:25, Alexey Brodkin wrote:
> On Thu, 2014-10-23 at 13:06 +0200, Stefan Roese wrote:
>> In preparation for the SoCFPGA support of the designware I2C driver,
>> convert this driver to the common CONFIG_SYS_I2C framework.
>>
>> This patch converts all users of this driver, this is:
>>
>> - ST spearxxx boards
>> - AXS101 (ARC700 platform)
>>
>> I couldn't test this patch on those boards. Only compile tested for all
>> spear boards. And tested on SoCFPGA.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> Cc: Heiko Schocher <hs@denx.de>
>> Cc: Marek Vasut <marex@denx.de>
>> Cc: Vipin Kumar <vipin.kumar@st.com>
>> Cc: Alexey Brodkin <abrodkin@synopsys.com>
>> ---
>>   arch/arm/cpu/arm926ejs/spear/cpu.c |   2 +-
>>   drivers/i2c/Makefile               |   2 +-
>>   drivers/i2c/designware_i2c.c       | 294 ++++++++++++++++---------------------
>>   include/configs/axs101.h           |   9 +-
>>   include/configs/spear-common.h     |   4 +-
>>   include/configs/x600.h             |   4 +-
>>   6 files changed, 142 insertions(+), 173 deletions(-)
>
>> -static struct i2c_regs *i2c_regs_p =
>> -    (struct i2c_regs *)CONFIG_SYS_I2C_BASE;
>> +	default:
>> +		printf("wrong hwadapnr: %d\n", adap->hwadapnr);
>> +	}
>
> Well, I'd say "wrong hwadapnr" is not very informative.
> Maybe something more human-friendly?

Yes, now that you mention it, this really is ugly. Copy-n-pasted from 
some other driver. I'll change it in the next version.

Thanks,
Stefan

      reply	other threads:[~2014-10-24  5:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-23 11:06 [U-Boot] [PATCH] i2c: designware: Convert driver to multibus/multiadapter framework Stefan Roese
2014-10-23 15:31 ` Marek Vasut
2014-10-23 17:25 ` Alexey Brodkin
2014-10-24  5:57   ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5449EA3F.4080900@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox