* [U-Boot] [PATCH] board: wandboard: add usb storage
@ 2014-10-23 20:43 Jeroen Hofstee
2014-10-23 20:47 ` Jeroen Hofstee
2014-10-23 21:02 ` [U-Boot] [PATCH v3] " Jeroen Hofstee
0 siblings, 2 replies; 10+ messages in thread
From: Jeroen Hofstee @ 2014-10-23 20:43 UTC (permalink / raw)
To: u-boot
Fabio Estevam <fabio.estevam@freescale.com> (maintainer:WANDBOARD BOARD)
Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
---
include/configs/wandboard.h | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/include/configs/wandboard.h b/include/configs/wandboard.h
index 37e3429..070ce92 100644
--- a/include/configs/wandboard.h
+++ b/include/configs/wandboard.h
@@ -84,6 +84,16 @@
#define CONFIG_CMD_FAT
#define CONFIG_DOS_PARTITION
+/* USB Configs */
+#define CONFIG_CMD_USB
+#define CONFIG_CMD_FAT
+#define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_MX6
+#define CONFIG_USB_STORAGE
+#define CONFIG_USB_MAX_CONTROLLER_COUNT 2
+#define CONFIG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW)
+#define CONFIG_MXC_USB_FLAGS 0
+
/* Ethernet Configuration */
#define CONFIG_CMD_PING
#define CONFIG_CMD_DHCP
--
2.1.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] board: wandboard: add usb storage
2014-10-23 20:43 [U-Boot] [PATCH] board: wandboard: add usb storage Jeroen Hofstee
@ 2014-10-23 20:47 ` Jeroen Hofstee
2014-10-23 20:49 ` Fabio Estevam
2014-10-23 21:02 ` [U-Boot] [PATCH v3] " Jeroen Hofstee
1 sibling, 1 reply; 10+ messages in thread
From: Jeroen Hofstee @ 2014-10-23 20:47 UTC (permalink / raw)
To: u-boot
Fabio Estevam <fabio.estevam@freescale.com> (maintainer:WANDBOARD BOARD)
Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
---
version 2: remove the duplicated CONFIG_CMD_FAT
---
include/configs/wandboard.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/include/configs/wandboard.h b/include/configs/wandboard.h
index 37e3429..1a9c4ab 100644
--- a/include/configs/wandboard.h
+++ b/include/configs/wandboard.h
@@ -84,6 +84,15 @@
#define CONFIG_CMD_FAT
#define CONFIG_DOS_PARTITION
+/* USB Configs */
+#define CONFIG_CMD_USB
+#define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_MX6
+#define CONFIG_USB_STORAGE
+#define CONFIG_USB_MAX_CONTROLLER_COUNT 2
+#define CONFIG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW)
+#define CONFIG_MXC_USB_FLAGS 0
+
/* Ethernet Configuration */
#define CONFIG_CMD_PING
#define CONFIG_CMD_DHCP
--
2.1.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] board: wandboard: add usb storage
2014-10-23 20:47 ` Jeroen Hofstee
@ 2014-10-23 20:49 ` Fabio Estevam
2014-10-23 20:55 ` Jeroen Hofstee
0 siblings, 1 reply; 10+ messages in thread
From: Fabio Estevam @ 2014-10-23 20:49 UTC (permalink / raw)
To: u-boot
Hi Jeroen,
On Thu, Oct 23, 2014 at 6:47 PM, Jeroen Hofstee <jeroen@myspectrum.nl> wrote:
> Fabio Estevam <fabio.estevam@freescale.com> (maintainer:WANDBOARD BOARD)
Patch looks good, but this commit log doesn't.
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] board: wandboard: add usb storage
2014-10-23 20:49 ` Fabio Estevam
@ 2014-10-23 20:55 ` Jeroen Hofstee
0 siblings, 0 replies; 10+ messages in thread
From: Jeroen Hofstee @ 2014-10-23 20:55 UTC (permalink / raw)
To: u-boot
Hello Fabio,
On 23-10-14 22:49, Fabio Estevam wrote:
> Hi Jeroen,
>
> On Thu, Oct 23, 2014 at 6:47 PM, Jeroen Hofstee <jeroen@myspectrum.nl> wrote:
>> Fabio Estevam <fabio.estevam@freescale.com> (maintainer:WANDBOARD BOARD)
> Patch looks good, but this commit log doesn't.
>
yes, I see, subject of the reposted patch is not correct
as well. Lets try it a third time ;)
Regards,
Jeroen
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH v3] board: wandboard: add usb storage
2014-10-23 20:43 [U-Boot] [PATCH] board: wandboard: add usb storage Jeroen Hofstee
2014-10-23 20:47 ` Jeroen Hofstee
@ 2014-10-23 21:02 ` Jeroen Hofstee
2014-10-23 21:04 ` Fabio Estevam
2014-10-30 9:07 ` Stefano Babic
1 sibling, 2 replies; 10+ messages in thread
From: Jeroen Hofstee @ 2014-10-23 21:02 UTC (permalink / raw)
To: u-boot
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
---
version 3:
- don't blindly copy get_mainter output
- don't forget the subject-prefix
version 2:
- remove the duplicated CONFIG_CMD_FAT
---
include/configs/wandboard.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/include/configs/wandboard.h b/include/configs/wandboard.h
index 37e3429..1a9c4ab 100644
--- a/include/configs/wandboard.h
+++ b/include/configs/wandboard.h
@@ -84,6 +84,15 @@
#define CONFIG_CMD_FAT
#define CONFIG_DOS_PARTITION
+/* USB Configs */
+#define CONFIG_CMD_USB
+#define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_MX6
+#define CONFIG_USB_STORAGE
+#define CONFIG_USB_MAX_CONTROLLER_COUNT 2
+#define CONFIG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW)
+#define CONFIG_MXC_USB_FLAGS 0
+
/* Ethernet Configuration */
#define CONFIG_CMD_PING
#define CONFIG_CMD_DHCP
--
2.1.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH v3] board: wandboard: add usb storage
2014-10-23 21:02 ` [U-Boot] [PATCH v3] " Jeroen Hofstee
@ 2014-10-23 21:04 ` Fabio Estevam
2014-10-23 21:17 ` Jeroen Hofstee
2014-10-30 9:07 ` Stefano Babic
1 sibling, 1 reply; 10+ messages in thread
From: Fabio Estevam @ 2014-10-23 21:04 UTC (permalink / raw)
To: u-boot
On Thu, Oct 23, 2014 at 7:02 PM, Jeroen Hofstee <jeroen@myspectrum.nl> wrote:
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
Acked-by: Fabio Estevam <fabio.estevam@freescale.com>
Please add Stefano on Cc next time.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH v3] board: wandboard: add usb storage
2014-10-23 21:04 ` Fabio Estevam
@ 2014-10-23 21:17 ` Jeroen Hofstee
2014-10-23 21:24 ` Fabio Estevam
2014-10-24 7:40 ` Stefano Babic
0 siblings, 2 replies; 10+ messages in thread
From: Jeroen Hofstee @ 2014-10-23 21:17 UTC (permalink / raw)
To: u-boot
Hello Fabio,
On 23-10-14 23:04, Fabio Estevam wrote:
> On Thu, Oct 23, 2014 at 7:02 PM, Jeroen Hofstee <jeroen@myspectrum.nl> wrote:
>> Cc: Fabio Estevam <fabio.estevam@freescale.com>
>> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> Acked-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Please add Stefano on Cc next time.
I would have normally, but get_maintainer instructed me
not to do so. Shouldn't it be adjusted then to include the
responsible custodian as well if that is what we want?
Or should I use get_maintainer.pl differently? For the record,
I am not a linux developer, I don't know how the script is
commonly used.
Regards,
Jeroen
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH v3] board: wandboard: add usb storage
2014-10-23 21:17 ` Jeroen Hofstee
@ 2014-10-23 21:24 ` Fabio Estevam
2014-10-24 7:40 ` Stefano Babic
1 sibling, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2014-10-23 21:24 UTC (permalink / raw)
To: u-boot
On Thu, Oct 23, 2014 at 7:17 PM, Jeroen Hofstee <jeroen@myspectrum.nl> wrote:
>> Please add Stefano on Cc next time.
>
>
> I would have normally, but get_maintainer instructed me
> not to do so. Shouldn't it be adjusted then to include the
> responsible custodian as well if that is what we want?
Yes, I think it should.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH v3] board: wandboard: add usb storage
2014-10-23 21:17 ` Jeroen Hofstee
2014-10-23 21:24 ` Fabio Estevam
@ 2014-10-24 7:40 ` Stefano Babic
1 sibling, 0 replies; 10+ messages in thread
From: Stefano Babic @ 2014-10-24 7:40 UTC (permalink / raw)
To: u-boot
Hi Jeroen,
On 23/10/2014 23:17, Jeroen Hofstee wrote:
> Hello Fabio,
>
> On 23-10-14 23:04, Fabio Estevam wrote:
>> On Thu, Oct 23, 2014 at 7:02 PM, Jeroen Hofstee <jeroen@myspectrum.nl>
>> wrote:
>>> Cc: Fabio Estevam <fabio.estevam@freescale.com>
>>> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
>> Acked-by: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Please add Stefano on Cc next time.
>
> I would have normally, but get_maintainer instructed me
> not to do so. Shouldn't it be adjusted then to include the
> responsible custodian as well if that is what we want?
>
Yes - it looks like that the script must be still adjusted.
> Or should I use get_maintainer.pl differently? For the record,
> I am not a linux developer, I don't know how the script is
> commonly used.
IMHO it is easier in the kernel, because each subsystem is isolated and
has its own ML. On U-Boot, we are working together in the same ML and
then we have to assign each single patch to the related custodian into
patchork. Sending the patch directly in CC to the custodian helps this
process.
Regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH v3] board: wandboard: add usb storage
2014-10-23 21:02 ` [U-Boot] [PATCH v3] " Jeroen Hofstee
2014-10-23 21:04 ` Fabio Estevam
@ 2014-10-30 9:07 ` Stefano Babic
1 sibling, 0 replies; 10+ messages in thread
From: Stefano Babic @ 2014-10-30 9:07 UTC (permalink / raw)
To: u-boot
On 23/10/2014 23:02, Jeroen Hofstee wrote:
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
>
> ---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-10-30 9:07 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-23 20:43 [U-Boot] [PATCH] board: wandboard: add usb storage Jeroen Hofstee
2014-10-23 20:47 ` Jeroen Hofstee
2014-10-23 20:49 ` Fabio Estevam
2014-10-23 20:55 ` Jeroen Hofstee
2014-10-23 21:02 ` [U-Boot] [PATCH v3] " Jeroen Hofstee
2014-10-23 21:04 ` Fabio Estevam
2014-10-23 21:17 ` Jeroen Hofstee
2014-10-23 21:24 ` Fabio Estevam
2014-10-24 7:40 ` Stefano Babic
2014-10-30 9:07 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox