From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch] mmc: fsl_esdhc: fix f_max retrieval during init
Date: Fri, 24 Oct 2014 13:35:42 +0200 [thread overview]
Message-ID: <544A398E.6080706@denx.de> (raw)
In-Reply-To: <1414143893-18202-1-git-send-email-list-09_u-boot@tqsc.de>
Hi Markus,
On 24/10/2014 11:44, Markus Niebel wrote:
> From: Markus Niebel <Markus.Niebel@tq-group.com>
>
> for multi instance API we use struct fsl_esdhc_cfg to
> pass the clock rate. Do not set f_max from global data,
> since this is wrong for multi instance case.
>
> Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
> ---
> drivers/mmc/fsl_esdhc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
> index 2640607..8a1a461 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -610,7 +610,7 @@ int fsl_esdhc_initialize(bd_t *bis, struct fsl_esdhc_cfg *cfg)
> #endif
>
> cfg->cfg.f_min = 400000;
> - cfg->cfg.f_max = min(gd->arch.sdhc_clk, 52000000);
> + cfg->cfg.f_max = min(cfg->sdhc_clk, 52000000);
>
> cfg->cfg.b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT;
Just a note for PowerPC users: as far I can see, PowerPC boards should
continue to work, because fsl_esdhc_mmc_init() backup gd->arch.sdhc into
cfg->sdhc_clk. Anyway, it would be not bad if patch could be tested even
on those boards.
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2014-10-24 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 9:44 [U-Boot] [Patch] mmc: fsl_esdhc: fix f_max retrieval during init Markus Niebel
2014-10-24 11:35 ` Stefano Babic [this message]
2014-10-27 23:19 ` Eric Nelson
2014-11-25 17:47 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544A398E.6080706@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox