From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 1/1] odroid: Turn blue LED on in u-boot
Date: Mon, 27 Oct 2014 12:35:18 +0100 [thread overview]
Message-ID: <544E2DF6.1060603@samsung.com> (raw)
In-Reply-To: <1412893242-10648-1-git-send-email-suriyan.r@gmail.com>
Hello Suriyan,
On 10/10/2014 12:20 AM, Suriyan Ramasami wrote:
> To indicate that u-boot is active turn on the blue LED.
>
> Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
> ---
> board/samsung/odroid/odroid.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c
> index fd5d2d2..391a287 100644
> --- a/board/samsung/odroid/odroid.c
> +++ b/board/samsung/odroid/odroid.c
> @@ -374,6 +374,9 @@ static void board_gpio_init(void)
> gpio_set_pull(EXYNOS4X12_GPIO_X31, S5P_GPIO_PULL_UP);
> gpio_set_drv(EXYNOS4X12_GPIO_X31, S5P_GPIO_DRV_4X);
> gpio_direction_input(EXYNOS4X12_GPIO_X31);
> +
> + /* Enable blue LED */
Here you will need to add gpio_request() call, e.g.
http://patchwork.ozlabs.org/patch/403197/
> + gpio_direction_output(EXYNOS4X12_GPIO_C10, 0);
> }
>
> static int pmic_init_max77686(void)
>
This looks good, but please wait until the patch series merge:
http://patchwork.ozlabs.org/patch/403186/ (starts from this commit)
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
next prev parent reply other threads:[~2014-10-27 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 22:20 [U-Boot] [PATCH v1 1/1] odroid: Turn blue LED on in u-boot Suriyan Ramasami
2014-10-27 11:35 ` Przemyslaw Marczak [this message]
2014-10-27 18:59 ` Suriyan Ramasami
2014-10-28 7:52 ` Przemyslaw Marczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E2DF6.1060603@samsung.com \
--to=p.marczak@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox