[U-Boot] [PATCH] tools/kwbimage: Fix compilation warning

Stefan Roese
2014-10-27T16:47:15Z

Hi Wolfgang,

On 27.10.2014 14:34, Wolfgang Denk wrote:
>>>> + switch (version) {
>>>> + /*
>>>> + * Fallback to version 0 is no version is provided in the
>>>> + * cfg file
>>>> + */
>>>> + case -1:
> ...
>
>>> What exactly is the difference between return code -1 (no version is
>>> provided and you fall back to using version 0), and the default case?
>>>
>>> To me these look the same?
>>
>> Perhaps the error message is a bit misleading. The "default:" case is
>> for unsupported versions. E.g. if "VERSION 3" would have been provided
>> in the cfg file.
>>
>> Should I rephrase the error message in the next patch version? To
>> something like this:
>
> In this case not the error message is incorrect, but the comment
> above is misleading. Instead of "no version is provided" it should
> probably read "if no supported version is provided" (note: please
> also fix the typo, i.e. "if" instead of "is").

The fallback in the comment above refers to "version == -1". As the
function image_get_version() returns -1 if no VERSION string is found in
the config file. So I think the comment is quite accurate.

Thanks,
Stefan