From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Mon, 27 Oct 2014 17:47:15 +0100
Subject: [U-Boot] [PATCH] tools/kwbimage: Fix compilation warning
In-Reply-To: <20141027133446.CC665382FFB@gemini.denx.de>
References: <1414412953-25615-1-git-send-email-sr@denx.de>
	<20141027125743.122C9380909@gemini.denx.de>
	<544E4412.60603@denx.de>
	<20141027133446.CC665382FFB@gemini.denx.de>
Message-ID: <544E7713.7010609@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

On 27.10.2014 14:34, Wolfgang Denk wrote:
>>>> +	switch (version) {
>>>> +		/*
>>>> +		 * Fallback to version 0 is no version is provided in the
>>>> +		 * cfg file
>>>> +		 */
>>>> +	case -1:
> ...
>
>>> What exactly is the difference between return code -1 (no version is
>>> provided and you fall back to using version 0), and the default case?
>>>
>>> To me these look the same?
>>
>> Perhaps the error message is a bit misleading. The "default:" case is
>> for unsupported versions. E.g. if "VERSION 3" would have been provided
>> in the cfg file.
>>
>> Should I rephrase the error message in the next patch version? To
>> something like this:
>
> In this case not the error message is incorrect, but the comment
> above is misleading.  Instead of "no version is provided" it should
> probably read "if no supported version is provided" (note: please
> also fix the typo, i.e. "if" instead of "is").

The fallback in the comment above refers to "version == -1". As the 
function image_get_version() returns -1 if no VERSION string is found in 
the config file. So I think the comment is quite accurate.

Thanks,
Stefan