From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/14] mmc: s5p: set SD detection pin as input
Date: Tue, 28 Oct 2014 14:14:09 +0900 [thread overview]
Message-ID: <544F2621.5000307@samsung.com> (raw)
In-Reply-To: <1414165510-10383-2-git-send-email-p.marczak@samsung.com>
Hi, Przemyslaw.
On 10/25/2014 12:44 AM, Przemyslaw Marczak wrote:
> The SD Card slot detection pin should be configured as input.
>
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> ---
> drivers/mmc/s5p_sdhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c
> index 0dea45d..a5d3487 100644
> --- a/drivers/mmc/s5p_sdhci.c
> +++ b/drivers/mmc/s5p_sdhci.c
> @@ -123,7 +123,7 @@ static int do_sdhci_init(struct sdhci_host *host)
> if (fdt_gpio_isvalid(&host->cd_gpio)) {
> sprintf(str, "sdhci%d_cd", host->index & 0xf);
> gpio_request(host->cd_gpio.gpio, str);
> - gpio_direction_output(host->cd_gpio.gpio, 1);
> + gpio_direction_input(host->cd_gpio.gpio);
Input is right?
Best Regards,
Jaehoon Chung
> if (gpio_get_value(host->cd_gpio.gpio))
> return -ENODEV;
>
>
next prev parent reply other threads:[~2014-10-28 5:14 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 15:44 [U-Boot] [PATCH 00/14] Set of fixes for Exynos4xxx boards Przemyslaw Marczak
2014-10-24 15:44 ` [U-Boot] [PATCH 01/14] mmc: s5p: set SD detection pin as input Przemyslaw Marczak
2014-10-28 1:01 ` Simon Glass
2014-10-28 1:15 ` Simon Glass
2014-10-28 1:28 ` Simon Glass
2014-10-28 5:14 ` Jaehoon Chung [this message]
2014-10-28 7:15 ` Przemyslaw Marczak
2014-10-24 15:44 ` [U-Boot] [PATCH 02/14] exynos: common: enable generic fs operations Przemyslaw Marczak
2014-10-28 1:09 ` Simon Glass
2014-10-28 1:28 ` Simon Glass
2014-10-24 15:44 ` [U-Boot] [PATCH 03/14] exynos4/4x12: cpu: add extra gpio base addresses Przemyslaw Marczak
2014-10-28 1:10 ` Simon Glass
2014-10-28 7:22 ` Przemyslaw Marczak
2014-10-24 15:44 ` [U-Boot] [PATCH 04/14] exynos4/4x12: gpio: use gpio extra " Przemyslaw Marczak
2014-10-28 1:10 ` Simon Glass
2014-10-28 7:24 ` Przemyslaw Marczak
2014-10-24 15:45 ` [U-Boot] [PATCH 05/14] exynos4412: dts: fix bad gpio order in pinctrl Przemyslaw Marczak
2014-10-28 1:11 ` Simon Glass
2014-10-28 1:29 ` Simon Glass
2014-10-24 15:45 ` [U-Boot] [PATCH 06/14] exynos4412: dts: adjust pinctrl-uboot to changed gpio order Przemyslaw Marczak
2014-10-28 1:11 ` Simon Glass
2014-10-28 1:29 ` Simon Glass
2014-10-24 15:45 ` [U-Boot] [PATCH 07/14] exynos4210: dts: fix gpio offset in pinctrl-uboot Przemyslaw Marczak
2014-10-28 1:11 ` Simon Glass
2014-10-28 1:29 ` Simon Glass
2014-10-24 15:45 ` [U-Boot] [PATCH 08/14] universal: request soft i2c gpio Przemyslaw Marczak
2014-10-28 1:12 ` Simon Glass
2014-10-28 1:29 ` Simon Glass
2014-10-24 15:45 ` [U-Boot] [PATCH 08/14] universal: request soft i2c/spi gpio Przemyslaw Marczak
2014-10-24 15:53 ` Przemyslaw Marczak
2014-10-24 15:45 ` [U-Boot] [PATCH 09/14] universal: dts: adjust gpio numbers to new api Przemyslaw Marczak
2014-10-28 1:12 ` Simon Glass
2014-10-28 1:29 ` Simon Glass
2014-10-24 15:45 ` [U-Boot] [PATCH 10/14] trats: " Przemyslaw Marczak
2014-10-28 1:12 ` Simon Glass
2014-10-28 1:29 ` Simon Glass
2014-10-24 15:45 ` [U-Boot] [PATCH 11/14] trats2: dts: adjust gpio numbers after gpio rework Przemyslaw Marczak
2014-10-28 1:12 ` Simon Glass
2014-10-28 1:29 ` Simon Glass
2014-10-24 15:45 ` [U-Boot] [PATCH 12/14] odroid: dts: adjust sd cd-gpios for SD Card Przemyslaw Marczak
2014-10-28 1:12 ` Simon Glass
2014-10-28 1:29 ` Simon Glass
2014-10-24 15:45 ` [U-Boot] [PATCH 13/14] odroid: dts: fix name of included dtsi Przemyslaw Marczak
2014-10-28 1:12 ` Simon Glass
2014-10-28 1:29 ` Simon Glass
2014-10-24 15:45 ` [U-Boot] [PATCH 14/14] odroid: adjust gpio calls to dm gpio api Przemyslaw Marczak
2014-10-28 1:13 ` Simon Glass
2014-10-28 7:27 ` Przemyslaw Marczak
2014-10-27 9:24 ` [U-Boot] [PATCH 00/14] Set of fixes for Exynos4xxx boards Przemyslaw Marczak
2014-10-27 18:48 ` Simon Glass
2014-10-28 1:31 ` Simon Glass
2014-10-28 7:33 ` Przemyslaw Marczak
2014-10-28 16:31 ` [U-Boot] [PATCH 1/3] exynos4/4x12: cpu: add extra gpio base addresses Przemyslaw Marczak
2014-10-28 16:31 ` [U-Boot] [PATCH 2/3] exynos4/4x12: gpio: use gpio extra " Przemyslaw Marczak
2014-10-29 2:59 ` Simon Glass
2014-10-30 13:54 ` Minkyu Kang
2014-11-04 9:29 ` Przemyslaw Marczak
2014-11-04 10:50 ` Minkyu Kang
2014-10-28 16:31 ` [U-Boot] [PATCH 3/3] odroid: adjust gpio calls to dm gpio api Przemyslaw Marczak
2014-10-29 2:58 ` Simon Glass
2014-10-30 13:54 ` Minkyu Kang
2014-10-28 16:40 ` [U-Boot] [PATCH 1/3] exynos4/4x12: cpu: add extra gpio base addresses Przemyslaw Marczak
2014-10-29 2:59 ` Simon Glass
2014-10-30 13:54 ` Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544F2621.5000307@samsung.com \
--to=jh80.chung@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox