From mboxrd@z Thu Jan 1 00:00:00 1970 From: Przemyslaw Marczak Date: Tue, 28 Oct 2014 08:15:43 +0100 Subject: [U-Boot] [PATCH 01/14] mmc: s5p: set SD detection pin as input In-Reply-To: <544F2621.5000307@samsung.com> References: <1414165510-10383-1-git-send-email-p.marczak@samsung.com> <1414165510-10383-2-git-send-email-p.marczak@samsung.com> <544F2621.5000307@samsung.com> Message-ID: <544F429F.9080002@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello, On 10/28/2014 06:14 AM, Jaehoon Chung wrote: > Hi, Przemyslaw. > > On 10/25/2014 12:44 AM, Przemyslaw Marczak wrote: >> The SD Card slot detection pin should be configured as input. >> >> Signed-off-by: Przemyslaw Marczak >> --- >> drivers/mmc/s5p_sdhci.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c >> index 0dea45d..a5d3487 100644 >> --- a/drivers/mmc/s5p_sdhci.c >> +++ b/drivers/mmc/s5p_sdhci.c >> @@ -123,7 +123,7 @@ static int do_sdhci_init(struct sdhci_host *host) >> if (fdt_gpio_isvalid(&host->cd_gpio)) { >> sprintf(str, "sdhci%d_cd", host->index & 0xf); >> gpio_request(host->cd_gpio.gpio, str); >> - gpio_direction_output(host->cd_gpio.gpio, 1); >> + gpio_direction_input(host->cd_gpio.gpio); > > Input is right? > Yes, this works fine. The input value changes when you insert or remove the card, so I don't know why there was output. > Best Regards, > Jaehoon Chung >> if (gpio_get_value(host->cd_gpio.gpio)) >> return -ENODEV; >> >> > > Best Regards, -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com