From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nikita Kiryanov <nikita@compulab.co.il>
Date: Tue, 28 Oct 2014 14:58:12 +0200
Subject: [U-Boot] clang warning
In-Reply-To: <544ED917.8020305@myspectrum.nl>
References: <544ED917.8020305@myspectrum.nl>
Message-ID: <544F92E4.6030305@compulab.co.il>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Jeroen,

On 28/10/14 01:45, Jeroen Hofstee wrote:
> Hello Nikita,
>
> Commit dc383dd introduces the following clang warning:
>
> drivers/block/dwc_ahsata.c:881:35: warning: use of logical '&&' with
> constant operand [-Wconstant-logical-operand]
>          return readl(&(port_mmio->ssts)) && SATA_PORT_SSTS_DET_MASK;
>                                                                ^
> ~~~~~~~~~~~~~~~~~~~~~~~
> drivers/block/dwc_ahsata.c:881:35: note: use '&' for a bitwise operation
>
> Regards,
> Jeroen

Thanks for catching this. Indeed, this should be a bitwise AND. Patch
coming up.

-- 
Regards,
Nikita Kiryanov