From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 4/8] common: spl: Add interactive DDR debugger support for SPL image
Date: Tue, 28 Oct 2014 08:31:29 -0700 [thread overview]
Message-ID: <544FB6D1.4000901@freescale.com> (raw)
In-Reply-To: <20141027102949.413d29ad@lilith>
On 10/27/2014 02:29 AM, Albert ARIBAUD wrote:
> Hello Alison,
>
> On Fri, 17 Oct 2014 16:00:30 +0800, Alison Wang <b18965@freescale.com>
> wrote:
>> To support interactive DDR debugger, cli_simple.o, cli.o, cli_readline.o,
>> command.o, s_record.o, xyzModem.o and cmd_disk.o are all needed for
>> drivers/ddr/fsl/interactive.c.
>>
>> In current common/Makefile, the above .o files are only produced when
>> CONFIG_SPL_BUILD is disabled.
>>
>> For LS102xA, interactive DDR debugger is needed in SD/NAND boot too, and
>> I enabled CONFIG_FSL_DDR_INTERACTIVE. But according to the current
>> common/Makfile, all the above .o files are not produced in SPL part
>> because CONFIG_SPL_BUILD is enabled in SPL part, the following error
>> will be shown,
>>
>> drivers/ddr/fsl/built-in.o: In function `fsl_ddr_interactive':
>> /home/wangh/layerscape/u-boot/drivers/ddr/fsl/interactive.c:1871:
>> undefined reference to `cli_readline_into_buffer'
>> /home/wangh/layerscape/u-boot/drivers/ddr/fsl/interactive.c:1873:
>> undefined reference to `cli_simple_parse_line'
>> make[1]: *** [spl/u-boot-spl] Error 1
>> make: *** [spl/u-boot-spl] Error 2
>>
>> So this patch fixed this issue and the above .o files will be produced
>> no matter CONFIG_SPL_BUILD is enabled or disabled.
>>
>> Signed-off-by: Alison Wang <alison.wang@freescale.com>
>> ---
>> Change log:
>> v3: Gave more explaination in the commit.
>> v2: No change.
>
> This does not apply cleanly. Could you rebase and resubmit?
>
Albert,
Are you trying to test/apply this patch?
York
next prev parent reply other threads:[~2014-10-28 15:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 8:00 [U-Boot] [PATCH v3 0/8] Add SD/NAND boot support for LS1021AQDS/TWR board Alison Wang
2014-10-17 8:00 ` [U-Boot] [PATCH v3 1/8] ls102xa: pblimage: Add pblimage tool support for LS102xA Alison Wang
2014-10-17 8:00 ` [U-Boot] [PATCH v3 2/8] spl: Use u-boot.img instead of u-boot.bin Alison Wang
2014-10-17 8:00 ` [U-Boot] [PATCH v3 3/8] arm: spl: Add I2C linker list in generic .lds Alison Wang
2014-10-17 8:00 ` [U-Boot] [PATCH v3 4/8] common: spl: Add interactive DDR debugger support for SPL image Alison Wang
2014-10-27 9:29 ` Albert ARIBAUD
2014-10-28 1:48 ` Huan Wang
2014-11-17 23:00 ` York Sun
2014-11-18 7:02 ` Albert ARIBAUD
2014-11-18 17:07 ` York Sun
2014-12-01 19:07 ` York Sun
2014-12-03 7:15 ` Huan Wang
2014-10-28 15:31 ` York Sun [this message]
2014-10-17 8:00 ` [U-Boot] [PATCH v3 5/8] ls102xa: qixis: Add CONFIG_QIXIS_I2C_ACCESS macro Alison Wang
2014-10-17 8:00 ` [U-Boot] [PATCH v3 6/8] arm: ls102xa: Add SD boot support for LS1021AQDS board Alison Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544FB6D1.4000901@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox