From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Tue, 28 Oct 2014 08:31:29 -0700 Subject: [U-Boot] [PATCH v3 4/8] common: spl: Add interactive DDR debugger support for SPL image In-Reply-To: <20141027102949.413d29ad@lilith> References: <1413532834-10380-1-git-send-email-b18965@freescale.com> <1413532834-10380-5-git-send-email-b18965@freescale.com> <20141027102949.413d29ad@lilith> Message-ID: <544FB6D1.4000901@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/27/2014 02:29 AM, Albert ARIBAUD wrote: > Hello Alison, > > On Fri, 17 Oct 2014 16:00:30 +0800, Alison Wang > wrote: >> To support interactive DDR debugger, cli_simple.o, cli.o, cli_readline.o, >> command.o, s_record.o, xyzModem.o and cmd_disk.o are all needed for >> drivers/ddr/fsl/interactive.c. >> >> In current common/Makefile, the above .o files are only produced when >> CONFIG_SPL_BUILD is disabled. >> >> For LS102xA, interactive DDR debugger is needed in SD/NAND boot too, and >> I enabled CONFIG_FSL_DDR_INTERACTIVE. But according to the current >> common/Makfile, all the above .o files are not produced in SPL part >> because CONFIG_SPL_BUILD is enabled in SPL part, the following error >> will be shown, >> >> drivers/ddr/fsl/built-in.o: In function `fsl_ddr_interactive': >> /home/wangh/layerscape/u-boot/drivers/ddr/fsl/interactive.c:1871: >> undefined reference to `cli_readline_into_buffer' >> /home/wangh/layerscape/u-boot/drivers/ddr/fsl/interactive.c:1873: >> undefined reference to `cli_simple_parse_line' >> make[1]: *** [spl/u-boot-spl] Error 1 >> make: *** [spl/u-boot-spl] Error 2 >> >> So this patch fixed this issue and the above .o files will be produced >> no matter CONFIG_SPL_BUILD is enabled or disabled. >> >> Signed-off-by: Alison Wang >> --- >> Change log: >> v3: Gave more explaination in the commit. >> v2: No change. > > This does not apply cleanly. Could you rebase and resubmit? > Albert, Are you trying to test/apply this patch? York