From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeroen Hofstee Date: Tue, 28 Oct 2014 19:20:18 +0100 Subject: [U-Boot] [PATCH] dwc_ahsata: use bitwise operator in sata_port_status In-Reply-To: <1414501169-24947-1-git-send-email-nikita@compulab.co.il> References: <1414501169-24947-1-git-send-email-nikita@compulab.co.il> Message-ID: <544FDE62.30801@myspectrum.nl> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Nikita, On 28-10-14 13:59, Nikita Kiryanov wrote: > The logic of the return statement in sata_port_status() calls for a > bitwise 'AND' operator, not logical 'AND'. Fix the typo. > > Reported-by: Jeroen Hofstee > Cc: Jeroen Hofstee > Cc: Stefano Babic > Signed-off-by: Nikita Kiryanov > --- > drivers/block/dwc_ahsata.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/dwc_ahsata.c b/drivers/block/dwc_ahsata.c > index 29f478b..c68fd2f 100644 > --- a/drivers/block/dwc_ahsata.c > +++ b/drivers/block/dwc_ahsata.c > @@ -878,7 +878,7 @@ int sata_port_status(int dev, int port) > probe_ent = (struct ahci_probe_ent *)sata_dev_desc[dev].priv; > port_mmio = (struct sata_port_regs *)probe_ent->port[port].port_mmio; > > - return readl(&(port_mmio->ssts)) && SATA_PORT_SSTS_DET_MASK; > + return readl(&(port_mmio->ssts)) & SATA_PORT_SSTS_DET_MASK; > } > > /* And squashes a warning ;) Acked-By: Jeroen Hofstee Regards, Jeroen