From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: sunxi: Fix Ippo-q8h-v5 defconfig filename
Date: Wed, 29 Oct 2014 10:25:02 +0100 [thread overview]
Message-ID: <5450B26E.3070208@redhat.com> (raw)
In-Reply-To: <20141029144554.6F0C.AA925319@jp.panasonic.com>
Hi,
On 10/29/2014 06:45 AM, Masahiro Yamada wrote:
> Hi Hans,
>
>
> On Fri, 24 Oct 2014 10:11:25 +0200
> Hans de Goede <hdegoede@redhat.com> wrote:
>
>> Hi,
>>
>> On 10/24/2014 10:07 AM, Chen-Yu Tsai wrote:
>>> The defconfig for Ippo-q8h-v5 was incorrectly committed as
>>> "Ippo_q8h". This patch renames it correctly, as well as
>>> correct a typo in my name in the maintainers listing.
>>>
>>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>>> ---
>>>
>>
>> Thats fast.
>>
>>> Feel free to squash this into
>>>
>>> 7b48d8c ARM: sunxi: Add Ippo-q8h-v5 A23 tablet board defconfig
>>
>> I'm afraid it is too late as I've already send out a pull-req
>> with that commit in it. If I had know you would be this fast I would
>> have waited 5 minutes :)
>>
>> Ah well. This fix is:
>>
>> Acked-by: Hans de Goede <hdegoede@redhat.com>
>>
>> And queued up in u-boot-sunxi/next.
>>
>
>
> No. This is almost like a bug fix.
>
> Please apply it on master and send a PR to Tom asap.
>
> Without this patch, tools/genboardscfg.py spits warnings:
>
> $ tools/genboardscfg.py
> WARNING: no status info for 'Ippo_q8h'
> WARNING: no maintainers for 'Ippo_q8h'
IMHO these 2 innocent warnings are not a good reason 2 rush out a fix,
and since the fix actually was buggy (which I've already fixed
in u-boot-sunxi/next but the original fix was no good), it is a good
thing this was not rushed out.
Regards,
Hans
prev parent reply other threads:[~2014-10-29 9:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 8:07 [U-Boot] [PATCH] ARM: sunxi: Fix Ippo-q8h-v5 defconfig filename Chen-Yu Tsai
2014-10-24 8:11 ` Hans de Goede
2014-10-24 11:41 ` Hans de Goede
2014-10-29 5:45 ` Masahiro Yamada
2014-10-29 9:25 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5450B26E.3070208@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox