* [U-Boot] [PATCH] ARM: sunxi: Fix Ippo-q8h-v5 defconfig filename
@ 2014-10-24 8:07 Chen-Yu Tsai
2014-10-24 8:11 ` Hans de Goede
0 siblings, 1 reply; 5+ messages in thread
From: Chen-Yu Tsai @ 2014-10-24 8:07 UTC (permalink / raw)
To: u-boot
The defconfig for Ippo-q8h-v5 was incorrectly committed as
"Ippo_q8h". This patch renames it correctly, as well as
correct a typo in my name in the maintainers listing.
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
Feel free to squash this into
7b48d8c ARM: sunxi: Add Ippo-q8h-v5 A23 tablet board defconfig
Sorry for overlooking this.
---
configs/Ippo_q8h_defconfig => Ippo_q8h_v5_defconfig | 0
board/sunxi/MAINTAINERS | 2 +-
2 files changed, 1 insertion(+), 1 deletion(-)
rename configs/Ippo_q8h_defconfig => Ippo_q8h_v5_defconfig (100%)
diff --git a/configs/Ippo_q8h_defconfig b/Ippo_q8h_v5_defconfig
similarity index 100%
rename from configs/Ippo_q8h_defconfig
rename to Ippo_q8h_v5_defconfig
diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS
index febd126..702b18b 100644
--- a/board/sunxi/MAINTAINERS
+++ b/board/sunxi/MAINTAINERS
@@ -52,6 +52,6 @@ S: Maintained
F: configs/Colombus_defconfig
IPPO-Q8H-V5 BOARD
-M: CHen-Yu Tsai <wens@csie.org>
+M: Chen-Yu Tsai <wens@csie.org>
S: Maintained
F: configs/Ippo_q8h_v5_defconfig
--
2.1.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] ARM: sunxi: Fix Ippo-q8h-v5 defconfig filename
2014-10-24 8:07 [U-Boot] [PATCH] ARM: sunxi: Fix Ippo-q8h-v5 defconfig filename Chen-Yu Tsai
@ 2014-10-24 8:11 ` Hans de Goede
2014-10-24 11:41 ` Hans de Goede
2014-10-29 5:45 ` Masahiro Yamada
0 siblings, 2 replies; 5+ messages in thread
From: Hans de Goede @ 2014-10-24 8:11 UTC (permalink / raw)
To: u-boot
Hi,
On 10/24/2014 10:07 AM, Chen-Yu Tsai wrote:
> The defconfig for Ippo-q8h-v5 was incorrectly committed as
> "Ippo_q8h". This patch renames it correctly, as well as
> correct a typo in my name in the maintainers listing.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>
Thats fast.
> Feel free to squash this into
>
> 7b48d8c ARM: sunxi: Add Ippo-q8h-v5 A23 tablet board defconfig
I'm afraid it is too late as I've already send out a pull-req
with that commit in it. If I had know you would be this fast I would
have waited 5 minutes :)
Ah well. This fix is:
Acked-by: Hans de Goede <hdegoede@redhat.com>
And queued up in u-boot-sunxi/next.
Regards,
Hans
>
> Sorry for overlooking this.
> ---
> configs/Ippo_q8h_defconfig => Ippo_q8h_v5_defconfig | 0
> board/sunxi/MAINTAINERS | 2 +-
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename configs/Ippo_q8h_defconfig => Ippo_q8h_v5_defconfig (100%)
>
> diff --git a/configs/Ippo_q8h_defconfig b/Ippo_q8h_v5_defconfig
> similarity index 100%
> rename from configs/Ippo_q8h_defconfig
> rename to Ippo_q8h_v5_defconfig
> diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS
> index febd126..702b18b 100644
> --- a/board/sunxi/MAINTAINERS
> +++ b/board/sunxi/MAINTAINERS
> @@ -52,6 +52,6 @@ S: Maintained
> F: configs/Colombus_defconfig
>
> IPPO-Q8H-V5 BOARD
> -M: CHen-Yu Tsai <wens@csie.org>
> +M: Chen-Yu Tsai <wens@csie.org>
> S: Maintained
> F: configs/Ippo_q8h_v5_defconfig
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] ARM: sunxi: Fix Ippo-q8h-v5 defconfig filename
2014-10-24 8:11 ` Hans de Goede
@ 2014-10-24 11:41 ` Hans de Goede
2014-10-29 5:45 ` Masahiro Yamada
1 sibling, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2014-10-24 11:41 UTC (permalink / raw)
To: u-boot
Hi,
On 10/24/2014 10:11 AM, Hans de Goede wrote:
> Hi,
>
> On 10/24/2014 10:07 AM, Chen-Yu Tsai wrote:
>> The defconfig for Ippo-q8h-v5 was incorrectly committed as
>> "Ippo_q8h". This patch renames it correctly, as well as
>> correct a typo in my name in the maintainers listing.
>>
>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>> ---
>>
>
> Thats fast.
>
>> Feel free to squash this into
>>
>> 7b48d8c ARM: sunxi: Add Ippo-q8h-v5 A23 tablet board defconfig
>
> I'm afraid it is too late as I've already send out a pull-req
> with that commit in it. If I had know you would be this fast I would
> have waited 5 minutes :)
>
> Ah well. This fix is:
>
> Acked-by: Hans de Goede <hdegoede@redhat.com>
Erm, you've accidentally not only renamed it but also moved it from
u-boot/configs to just u-boot. Will fix myself.
Regards,
Hans
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] ARM: sunxi: Fix Ippo-q8h-v5 defconfig filename
2014-10-24 8:11 ` Hans de Goede
2014-10-24 11:41 ` Hans de Goede
@ 2014-10-29 5:45 ` Masahiro Yamada
2014-10-29 9:25 ` Hans de Goede
1 sibling, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2014-10-29 5:45 UTC (permalink / raw)
To: u-boot
Hi Hans,
On Fri, 24 Oct 2014 10:11:25 +0200
Hans de Goede <hdegoede@redhat.com> wrote:
> Hi,
>
> On 10/24/2014 10:07 AM, Chen-Yu Tsai wrote:
> > The defconfig for Ippo-q8h-v5 was incorrectly committed as
> > "Ippo_q8h". This patch renames it correctly, as well as
> > correct a typo in my name in the maintainers listing.
> >
> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> > ---
> >
>
> Thats fast.
>
> > Feel free to squash this into
> >
> > 7b48d8c ARM: sunxi: Add Ippo-q8h-v5 A23 tablet board defconfig
>
> I'm afraid it is too late as I've already send out a pull-req
> with that commit in it. If I had know you would be this fast I would
> have waited 5 minutes :)
>
> Ah well. This fix is:
>
> Acked-by: Hans de Goede <hdegoede@redhat.com>
>
> And queued up in u-boot-sunxi/next.
>
No. This is almost like a bug fix.
Please apply it on master and send a PR to Tom asap.
Without this patch, tools/genboardscfg.py spits warnings:
$ tools/genboardscfg.py
WARNING: no status info for 'Ippo_q8h'
WARNING: no maintainers for 'Ippo_q8h'
It is up to you to apply trivial changes to your next branch,
but please notice global changes are always happening on
the upstream, for ex.
http://patchwork.ozlabs.org/patch/404351/
Of course, it is OK if you want to fix conflicts by yourself lator.
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] ARM: sunxi: Fix Ippo-q8h-v5 defconfig filename
2014-10-29 5:45 ` Masahiro Yamada
@ 2014-10-29 9:25 ` Hans de Goede
0 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2014-10-29 9:25 UTC (permalink / raw)
To: u-boot
Hi,
On 10/29/2014 06:45 AM, Masahiro Yamada wrote:
> Hi Hans,
>
>
> On Fri, 24 Oct 2014 10:11:25 +0200
> Hans de Goede <hdegoede@redhat.com> wrote:
>
>> Hi,
>>
>> On 10/24/2014 10:07 AM, Chen-Yu Tsai wrote:
>>> The defconfig for Ippo-q8h-v5 was incorrectly committed as
>>> "Ippo_q8h". This patch renames it correctly, as well as
>>> correct a typo in my name in the maintainers listing.
>>>
>>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>>> ---
>>>
>>
>> Thats fast.
>>
>>> Feel free to squash this into
>>>
>>> 7b48d8c ARM: sunxi: Add Ippo-q8h-v5 A23 tablet board defconfig
>>
>> I'm afraid it is too late as I've already send out a pull-req
>> with that commit in it. If I had know you would be this fast I would
>> have waited 5 minutes :)
>>
>> Ah well. This fix is:
>>
>> Acked-by: Hans de Goede <hdegoede@redhat.com>
>>
>> And queued up in u-boot-sunxi/next.
>>
>
>
> No. This is almost like a bug fix.
>
> Please apply it on master and send a PR to Tom asap.
>
> Without this patch, tools/genboardscfg.py spits warnings:
>
> $ tools/genboardscfg.py
> WARNING: no status info for 'Ippo_q8h'
> WARNING: no maintainers for 'Ippo_q8h'
IMHO these 2 innocent warnings are not a good reason 2 rush out a fix,
and since the fix actually was buggy (which I've already fixed
in u-boot-sunxi/next but the original fix was no good), it is a good
thing this was not rushed out.
Regards,
Hans
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-10-29 9:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-24 8:07 [U-Boot] [PATCH] ARM: sunxi: Fix Ippo-q8h-v5 defconfig filename Chen-Yu Tsai
2014-10-24 8:11 ` Hans de Goede
2014-10-24 11:41 ` Hans de Goede
2014-10-29 5:45 ` Masahiro Yamada
2014-10-29 9:25 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox