From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikita Kiryanov Date: Wed, 29 Oct 2014 17:34:59 +0200 Subject: [U-Boot] [PATCH 3/3] common: introduce board_preboot_os hook In-Reply-To: References: <1414588105-14365-1-git-send-email-nikita@compulab.co.il> <1414588105-14365-4-git-send-email-nikita@compulab.co.il> <5450EB88.7030704@myspectrum.nl> Message-ID: <54510923.3080802@compulab.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Jeroen, Otavio, On 29/10/14 17:23, Otavio Salvador wrote: > On Wed, Oct 29, 2014 at 11:28 AM, Jeroen Hofstee wrote: >> On 29-10-14 14:08, Nikita Kiryanov wrote: >>> >>> Introduce board specific function board_preboot_os() to allow for board >>> specific config before we boot, and use it on cm_fx6 to power off sata >>> so that Linux will be able to setup it correctly. >>> >>> Signed-off-by: Nikita Kiryanov >>> Cc: Igor Grinberg >>> Cc: Stefano Babic >>> Cc: Tom Rini >> >> .. >>> >>> + >>> +void board_preboot_os(void) >>> +{ >>> + cm_fx6_sata_power(0); >>> +} >>> +/* Allow for board specific config before we boot */ >>> +__weak void board_preboot_os(void) >>> +{ >>> + /* please define board specific board_preboot_os() */ >>> +} >>> + >>> int boot_selected_os(int argc, char * const argv[], int state, >>> bootm_headers_t *images, boot_os_fn *boot_fn) >>> { >>> arch_preboot_os(); >>> + board_preboot_os(); >>> boot_fn(state, argc, argv, images); >> >> >> Can you also add a prototype for the board_preboot_os in say >> bootm.h or similiar and make sure those headers are included. >> (it will warn otherwise with W=1). > Sure. > and also split the patch in two. > Alright. -- Regards, Nikita Kiryanov