public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] buildman: using wrong libgcc.a
Date: Thu, 30 Oct 2014 21:57:39 +0100	[thread overview]
Message-ID: <5452A643.6000309@myspectrum.nl> (raw)
In-Reply-To: <5452A2A6.5000601@broadcom.com>

Hello Steve,

On 30-10-14 21:42, Steve Rae wrote:
> Hmmmm -- maybe it would be better to specify the entire path for the 
> CROSS_COMPILE, and not rely on the PATH to find the cross compile tools:
>
> diff --git a/tools/buildman/toolchain.py b/tools/buildman/toolchain.py
> index 27dc318..58c7b1f 100644
> --- a/tools/buildman/toolchain.py
> +++ b/tools/buildman/toolchain.py
> @@ -33,6 +33,7 @@ class Toolchain:
>          self.cross = os.path.basename(fname)[:-3]
>          pos = self.cross.find('-')
>          self.arch = self.cross[:pos] if pos != -1 else 'sandbox'
> +        self.cross = fname[:-3]
>

A bit off topic, but is it possible to stop adding these magic 3
constants. strlen("clang") != 3. strlen("cc") isn't either. Anyway
I am aware buildman is already full with it, so I am fine with
one more (for now).

Regards,
Jeroen

  reply	other threads:[~2014-10-30 20:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-30 16:57 [U-Boot] buildman: using wrong libgcc.a Steve Rae
2014-10-30 20:42 ` Steve Rae
2014-10-30 20:57   ` Jeroen Hofstee [this message]
2014-11-03 21:14     ` Simon Glass
2014-11-05 17:22       ` Steve Rae
2014-11-05 18:46       ` Jeroen Hofstee
2014-11-05 19:05         ` [U-Boot] buildman: using wrong libgcc.a (magic -3) Steve Rae
2014-11-05 19:09           ` Wolfgang Denk
2014-11-05 19:36             ` Steve Rae
2014-11-05 22:59               ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5452A643.6000309@myspectrum.nl \
    --to=jeroen@myspectrum.nl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox