From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bo Shen Date: Fri, 31 Oct 2014 09:55:34 +0800 Subject: [U-Boot] [v2 PATCH 10/12] arm, spl, at91: add at91sam9260 and at91sam9g45 spl support In-Reply-To: <545223DC.60502@denx.de> References: <1414656906-16632-1-git-send-email-hs@denx.de> <1414656906-16632-11-git-send-email-hs@denx.de> <54521028.30109@atmel.com> <545223DC.60502@denx.de> Message-ID: <5452EC16.9060806@atmel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Heiko, On 10/30/2014 07:41 PM, Heiko Schocher wrote: > Hello Bo, > > Am 30.10.2014 11:17, schrieb Bo Shen: >> Hi Heiko, >> >> On 10/30/2014 04:15 PM, Heiko Schocher wrote: >>> diff --git a/arch/arm/include/asm/arch-at91/at91_pmc.h >>> b/arch/arm/include/asm/arch-at91/at91_pmc.h >>> index 27331ff..5f64583 100644 >>> --- a/arch/arm/include/asm/arch-at91/at91_pmc.h >>> +++ b/arch/arm/include/asm/arch-at91/at91_pmc.h >>> @@ -95,7 +95,7 @@ typedef struct at91_pmc { >>> #define AT91_PMC_MCKR_CSS_MAIN 0x00000001 >>> #define AT91_PMC_MCKR_CSS_PLLA 0x00000002 >>> #define AT91_PMC_MCKR_CSS_PLLB 0x00000003 >>> -#define AT91_PMC_MCKR_CSS_MASK 0x00000003 >>> +#define AT91_PMC_MCKR_CSS_MASK 0x00000007 >> >> Where this come from, CSS only two bits. > > Good question ... looked again into the doc, it is only two bits. > >> >>> #ifdef CONFIG_SAMA5D3 >>> #define AT91_PMC_MCKR_PRES_1 0x00000000 >>> @@ -114,7 +114,7 @@ typedef struct at91_pmc { >>> #define AT91_PMC_MCKR_PRES_16 0x00000010 >>> #define AT91_PMC_MCKR_PRES_32 0x00000014 >>> #define AT91_PMC_MCKR_PRES_64 0x00000018 >>> -#define AT91_PMC_MCKR_PRES_MASK 0x0000001C >>> +#define AT91_PMC_MCKR_PRES_MASK 0x0000003C >> >> Ditto > > Hmm... no idea, why I changed this ... good catch! > > Is the rest of the patch (and the patchserie OK) ? Except one suggestion and nitpick sent just now, the rest patch seems good. For this whole series: Reviewed-by: Bo Shen > Then I can send a v3 ... > > bye, > Heiko Best Regards, Bo Shen