From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Fri, 31 Oct 2014 06:33:46 +0100 Subject: [U-Boot] [v2 PATCH 03/12] arm, at91, mpddrc: fix typo in ddr2_init() In-Reply-To: <5452EC01.4030308@atmel.com> References: <1414656906-16632-1-git-send-email-hs@denx.de> <1414656906-16632-4-git-send-email-hs@denx.de> <5452EC01.4030308@atmel.com> Message-ID: <54531F3A.4010601@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Bo, Am 31.10.2014 02:55, schrieb Bo Shen: > Hi Heiko, > > On 10/30/2014 04:14 PM, Heiko Schocher wrote: >> use the configure value for computing the ba_off value >> not the value from the cr register. This leaded in a >> wrong ram configuration on the upcoming corvus spl board >> support. >> >> Signed-off-by: Heiko Schocher >> Reviewed-by: Andreas Bie?mann >> >> --- >> >> Changes in v2: >> add Reviewed-by: Andreas Bie?mann >> >> arch/arm/cpu/at91-common/mpddrc.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/cpu/at91-common/mpddrc.c b/arch/arm/cpu/at91-common/mpddrc.c >> index 8136396..76668d2 100644 >> --- a/arch/arm/cpu/at91-common/mpddrc.c >> +++ b/arch/arm/cpu/at91-common/mpddrc.c >> @@ -26,7 +26,8 @@ int ddr2_init(const unsigned int ram_address, >> /* Compute bank offset according to NC in configuration register */ >> ba_off = (mpddr_value->cr & ATMEL_MPDDRC_CR_NC_MASK) + 9; >> if (!(mpddr_value->cr & ATMEL_MPDDRC_CR_DECOD_INTERLEAVED)) >> - ba_off += ((mpddr->cr & ATMEL_MPDDRC_CR_NR_MASK) >> 2) + 11; >> + ba_off += ((mpddr_value->cr & ATMEL_MPDDRC_CR_NR_MASK) >> 2) >> + + 11; > > As Andreas suggested, can we ignore the 80 character's warning here? Ok, changes this ... so I send a v3. bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany