[U-Boot] [v2 PATCH 03/12] arm, at91, mpddrc: fix typo in ddr2_init()

Bo Shen
2014-10-31T01:55:13Z

Hi Heiko,

On 10/30/2014 04:14 PM, Heiko Schocher wrote:
> use the configure value for computing the ba_off value
> not the value from the cr register. This leaded in a
> wrong ram configuration on the upcoming corvus spl board
> support.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Reviewed-by: Andreas Bie?mann <andreas.devel@googlemail.com>
>
> ---
>
> Changes in v2:
> add Reviewed-by: Andreas Bie?mann <andreas.devel@googlemail.com>
>
> arch/arm/cpu/at91-common/mpddrc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/cpu/at91-common/mpddrc.c b/arch/arm/cpu/at91-common/mpddrc.c
> index 8136396..76668d2 100644
> --- a/arch/arm/cpu/at91-common/mpddrc.c
> +++ b/arch/arm/cpu/at91-common/mpddrc.c
> @@ -26,7 +26,8 @@ int ddr2_init(const unsigned int ram_address,
> /* Compute bank offset according to NC in configuration register */
> ba_off = (mpddr_value->cr & ATMEL_MPDDRC_CR_NC_MASK) + 9;
> if (!(mpddr_value->cr & ATMEL_MPDDRC_CR_DECOD_INTERLEAVED))
> - ba_off += ((mpddr->cr & ATMEL_MPDDRC_CR_NR_MASK) >> 2) + 11;
> + ba_off += ((mpddr_value->cr & ATMEL_MPDDRC_CR_NR_MASK) >> 2)
> + + 11;

As Andreas suggested, can we ignore the 80 character's warning here?

> ba_off += (mpddr_value->md & ATMEL_MPDDRC_MD_DBW_MASK) ? 1 : 2;
>
>

Best Regards,
Bo Shen