public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mtd, cfi, ubi: add missing writebufsize initialization
Date: Fri, 31 Oct 2014 10:44:21 +0100	[thread overview]
Message-ID: <545359F5.8040104@denx.de> (raw)
In-Reply-To: <1414748366-3208-1-git-send-email-hs@denx.de>

Hi Heiko,

On 31.10.2014 10:39, Heiko Schocher wrote:
> ff94bc40af3481d47546595ba73c136de6af6929 "mtd, ubi, ubifs: resync with Linux-3.14"
> introduced the writebufsize field in struct mtd_info, which
> is not initialized in the cfi_flash driver, which leads in
> not working ubi on cfi flashes. Fix it
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Reported-by: Andrew Ruder <andrew.ruder@elecsyscorp.com>
>
> ---
> @Andrew: could you test this patch, if it solves your issue?
>
>   drivers/mtd/cfi_mtd.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/cfi_mtd.c b/drivers/mtd/cfi_mtd.c
> index ac805ff..894858e 100644
> --- a/drivers/mtd/cfi_mtd.c
> +++ b/drivers/mtd/cfi_mtd.c
> @@ -226,6 +226,7 @@ int cfi_mtd_init(void)
>   		mtd->flags		= MTD_CAP_NORFLASH;
>   		mtd->size		= fi->size;
>   		mtd->writesize		= 1;
> +		mtd->writebufsize = mtd->writesize;
>

Small nitpicking comment: Could you please align the "=" to those lines 
above? Thanks!

Other than that:

Acked-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

  reply	other threads:[~2014-10-31  9:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-31  9:39 [U-Boot] [PATCH] mtd, cfi, ubi: add missing writebufsize initialization Heiko Schocher
2014-10-31  9:44 ` Stefan Roese [this message]
2014-10-31  9:45   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545359F5.8040104@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox