From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Fri, 31 Oct 2014 10:45:45 +0100 Subject: [U-Boot] [PATCH] mtd, cfi, ubi: add missing writebufsize initialization In-Reply-To: <545359F5.8040104@denx.de> References: <1414748366-3208-1-git-send-email-hs@denx.de> <545359F5.8040104@denx.de> Message-ID: <54535A49.3020106@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Stefan, Am 31.10.2014 10:44, schrieb Stefan Roese: > Hi Heiko, > > On 31.10.2014 10:39, Heiko Schocher wrote: >> ff94bc40af3481d47546595ba73c136de6af6929 "mtd, ubi, ubifs: resync with Linux-3.14" >> introduced the writebufsize field in struct mtd_info, which >> is not initialized in the cfi_flash driver, which leads in >> not working ubi on cfi flashes. Fix it >> >> Signed-off-by: Heiko Schocher >> Reported-by: Andrew Ruder >> >> --- >> @Andrew: could you test this patch, if it solves your issue? >> >> drivers/mtd/cfi_mtd.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mtd/cfi_mtd.c b/drivers/mtd/cfi_mtd.c >> index ac805ff..894858e 100644 >> --- a/drivers/mtd/cfi_mtd.c >> +++ b/drivers/mtd/cfi_mtd.c >> @@ -226,6 +226,7 @@ int cfi_mtd_init(void) >> mtd->flags = MTD_CAP_NORFLASH; >> mtd->size = fi->size; >> mtd->writesize = 1; >> + mtd->writebufsize = mtd->writesize; >> > > Small nitpicking comment: Could you please align the "=" to those lines above? Thanks! Hups ... sorry. > Other than that: > > Acked-by: Stefan Roese Thanks! bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany