From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Fri, 31 Oct 2014 13:31:19 +0100
Subject: [U-Boot] [v3 PATCH 02/12] arm,
 at91: add spi dataflash support for the taurus board
In-Reply-To: <CAD6G_RQcu0EkThxA_F68rNUUEsGCLf5LOA9ynmm6b3Lv98swMg@mail.gmail.com>
References: <1414740666-13337-1-git-send-email-hs@denx.de>
	<1414740666-13337-3-git-send-email-hs@denx.de>
	<CAD6G_RQcu0EkThxA_F68rNUUEsGCLf5LOA9ynmm6b3Lv98swMg@mail.gmail.com>
Message-ID: <54538117.5070606@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Jagan,

Am 31.10.2014 11:48, schrieb Jagan Teki:
> On 31 October 2014 13:00, Heiko Schocher<hs@denx.de>  wrote:
>> Signed-off-by: Heiko Schocher<hs@denx.de>
>> Reviewed-by: Bo Shen<voice.shen@atmel.com>
>>
>> ---
>>
>> Changes in v3:
>> add Reviewed-by from Bo Shen
>>
>> Changes in v2:
>> - add comment from Jagan Teki:
>>    - remove spi_init_f() from board file
>>    - remove CONFIG_SYS_SPI_WRITE_TOUT from board config file
>>      instead define a default in the spi driver ->  new patch for v2
>>
>>   board/siemens/taurus/taurus.c | 18 ++++++++++++++++++
>>   include/configs/taurus.h      | 10 ++++++++++
>>   2 files changed, 28 insertions(+)
>>
>> diff --git a/board/siemens/taurus/taurus.c b/board/siemens/taurus/taurus.c
>> index 673b302..76609c7 100644
>> --- a/board/siemens/taurus/taurus.c
>> +++ b/board/siemens/taurus/taurus.c
>> @@ -22,6 +22,8 @@
>>   #include<asm/arch/gpio.h>
>>   #include<asm/arch/at91sam9_sdramc.h>
>>   #include<atmel_mci.h>
>> +#include<asm/arch/at91_spi.h>
>> +#include<spi.h>
>>
>>   #include<net.h>
>>   #include<netdev.h>
>> @@ -127,6 +129,21 @@ int board_early_init_f(void)
>>          return 0;
>>   }
>>
>> +int spi_cs_is_valid(unsigned int bus, unsigned int cs)
>> +{
>> +       return bus == 0&&  cs == 0;
>> +}
>> +
>> +void spi_cs_activate(struct spi_slave *slave)
>> +{
>> +       at91_set_gpio_value(TAURUS_SPI_CS_PIN, 0);
>> +}
>> +
>> +void spi_cs_deactivate(struct spi_slave *slave)
>> +{
>> +       at91_set_gpio_value(TAURUS_SPI_CS_PIN, 1);
>> +}
>> +
>
> Please add all these stuff in drivers/spi/atmel_spi.c
>
> Did you see any issues?

Hmm.. this is board specific ... or?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany