public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/5] imx: gpt: Add High frequency clock source support for GPT
Date: Mon, 03 Nov 2014 11:23:21 +0100	[thread overview]
Message-ID: <54575799.9040402@denx.de> (raw)
In-Reply-To: <1414664459-3128-1-git-send-email-B37916@freescale.com>

Hi Ye,

On 30/10/2014 11:20, Ye.Li wrote:
> Introduce a new configuration "CONFIG_MXC_GPT_HCLK". When it is set,
> the GPT will select a high frequency clock as clock source.
> Otherwise, the GPT will stay to use 32Khz OSC as clock source.
> 
> In the implementation, since only the GPT on i.MX6 series provide the
> clock source option for 24Mhz OSC. For others (only i.MX5 and i.MX6
> compile the driver), if the configuration is set, the perclk will be
> selected as clock source.
> MX6Q/D Rev 1.0 and MX6SL are special in the implementation, because they
> don't have the 24Mhz OSC clock source option, so also select the perclk
> for them. For MX6SL, we will set the OSC 24Mhz to perclk in CCM, so
> eventually the clock comes from OSC 24Mhz.
> 
> Signed-off-by: Ye.Li <B37916@freescale.com>
> ---


After fixing the following checkpatch's warnings:

CHECK: Logical continuations should be on the previous line
#119: FILE: arch/arm/imx-common/timer.c:47:
+       if (((is_cpu_type(MXC_CPU_MX6Q) || is_cpu_type(MXC_CPU_MX6D))
                        +               && (is_soc_rev(CHIP_REV_1_0) > 0))

                CHECK: Logical continuations should be on the previous line
#120: FILE: arch/arm/imx-common/timer.c:48:
                +               && (is_soc_rev(CHIP_REV_1_0) > 0))
        +               || is_cpu_type(MXC_CPU_MX6DL) ||
is_cpu_type(MXC_CPU_MX6SOLO)

        CHECK: Logical continuations should be on the previous line
#121: FILE: arch/arm/imx-common/timer.c:49:
        +               || is_cpu_type(MXC_CPU_MX6DL) ||
is_cpu_type(MXC_CPU_MX6SOLO)
        +               || is_cpu_type(MXC_CPU_MX6SX))

        CHECK: Logical continuations should be on the previous line
#178: FILE: arch/arm/imx-common/timer.c:109:
        +               if (is_cpu_type(MXC_CPU_MX6DL) ||
is_cpu_type(MXC_CPU_MX6SOLO)
                        +                       ||
is_cpu_type(MXC_CPU_MX6SX)) {

CHECK: Alignment should match open parenthesis
#183: FILE: arch/arm/imx-common/timer.c:114:
               +                        __raw_writel((7 <<
GPTPR_PRESCALER24M_SHIFT),
                               +
                &cur_gpt->prescaler);


Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

      parent reply	other threads:[~2014-11-03 10:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-30 10:20 [U-Boot] [PATCH v3 1/5] imx: gpt: Add High frequency clock source support for GPT Ye.Li
2014-10-30 10:20 ` [U-Boot] [PATCH v3 2/5] imx: mx6sl: Add perclk_clk_sel bit define in CCM Ye.Li
2014-11-03 10:23   ` Stefano Babic
2014-10-30 10:20 ` [U-Boot] [PATCH v3 3/5] imx: mx6: Change the get_ipg_per_clk for OSC 24Mhz source Ye.Li
2014-11-03 10:24   ` Stefano Babic
2014-10-30 10:20 ` [U-Boot] [PATCH v3 4/5] imx: mx6sl: Set the preclk clock source to OSC 24Mhz Ye.Li
2014-11-03 10:24   ` Stefano Babic
2014-10-30 10:20 ` [U-Boot] [PATCH v3 5/5] imx: mx6: Enable high frequency clock source for GPT Ye.Li
2014-11-03 10:24   ` Stefano Babic
2014-11-03 10:23 ` Stefano Babic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54575799.9040402@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox