* [U-Boot] [PATCH] common.h: Add prototype of arch_preboot_os
@ 2014-11-04 7:14 Nobuhiro Iwamatsu
2014-11-04 7:50 ` Igor Grinberg
0 siblings, 1 reply; 3+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-11-04 7:14 UTC (permalink / raw)
To: u-boot
When we used arch_preboot_os() function because prototype of this is not
declared, following warning is output.
-----
warning: function declaration isn't a prototype [-Wstrict-prototypes]
-----
This adds prototype of arch_preboot_os() to include/common.h.
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
include/common.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/common.h b/include/common.h
index d5020c8..8ee9ca5 100644
--- a/include/common.h
+++ b/include/common.h
@@ -318,6 +318,9 @@ void board_show_dram(ulong size);
*/
int arch_fixup_fdt(void *blob);
+/* Set arch specific config before boot */
+void arch_preboot_os(void);
+
/* common/flash.c */
void flash_perror (int);
--
2.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] common.h: Add prototype of arch_preboot_os
2014-11-04 7:14 [U-Boot] [PATCH] common.h: Add prototype of arch_preboot_os Nobuhiro Iwamatsu
@ 2014-11-04 7:50 ` Igor Grinberg
2014-11-04 22:00 ` Nobuhiro Iwamatsu
0 siblings, 1 reply; 3+ messages in thread
From: Igor Grinberg @ 2014-11-04 7:50 UTC (permalink / raw)
To: u-boot
On 11/04/14 09:14, Nobuhiro Iwamatsu wrote:
> When we used arch_preboot_os() function because prototype of this is not
> declared, following warning is output.
Or.. you just need to include the correct file:
$ grep -nr arch_preboot_os include/
include/bootm.h:57:void arch_preboot_os(void);
>
> -----
> warning: function declaration isn't a prototype [-Wstrict-prototypes]
> -----
>
> This adds prototype of arch_preboot_os() to include/common.h.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
> include/common.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/common.h b/include/common.h
> index d5020c8..8ee9ca5 100644
> --- a/include/common.h
> +++ b/include/common.h
> @@ -318,6 +318,9 @@ void board_show_dram(ulong size);
> */
> int arch_fixup_fdt(void *blob);
>
> +/* Set arch specific config before boot */
> +void arch_preboot_os(void);
> +
> /* common/flash.c */
> void flash_perror (int);
>
>
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] common.h: Add prototype of arch_preboot_os
2014-11-04 7:50 ` Igor Grinberg
@ 2014-11-04 22:00 ` Nobuhiro Iwamatsu
0 siblings, 0 replies; 3+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-11-04 22:00 UTC (permalink / raw)
To: u-boot
Hi!
2014-11-04 16:50 GMT+09:00 Igor Grinberg <grinberg@compulab.co.il>:
> On 11/04/14 09:14, Nobuhiro Iwamatsu wrote:
>> When we used arch_preboot_os() function because prototype of this is not
>> declared, following warning is output.
>
> Or.. you just need to include the correct file:
>
> $ grep -nr arch_preboot_os include/
> include/bootm.h:57:void arch_preboot_os(void);
Oh, I see.
Thanks for your check.
Best regards,
Nobuhiro
--
Nobuhiro Iwamatsu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-04 22:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-04 7:14 [U-Boot] [PATCH] common.h: Add prototype of arch_preboot_os Nobuhiro Iwamatsu
2014-11-04 7:50 ` Igor Grinberg
2014-11-04 22:00 ` Nobuhiro Iwamatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox