From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] mmc: Board-specific MMC power initializations
Date: Tue, 04 Nov 2014 19:58:38 +0200 [thread overview]
Message-ID: <545913CE.6020609@compulab.co.il> (raw)
In-Reply-To: <20141104155611.GK15133@bill-the-cat>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Tom,
On 11/04/14 17:56, Tom Rini wrote:
> On Sat, Nov 01, 2014 at 11:35:43AM +0100, Paul Kocialkowski wrote:
>
>> Some devices may use non-standard combinations of regulators to power MMC:
>> this allows these devices to provide a board-specific MMC power init function
>> to set everything up in their own way.
>>
>> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
>> ---
>> drivers/mmc/mmc.c | 8 ++++++++
>> include/mmc.h | 2 ++
>> 2 files changed, 10 insertions(+)
>>
>> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
>> index 44a4feb..125f347 100644
>> --- a/drivers/mmc/mmc.c
>> +++ b/drivers/mmc/mmc.c
>> @@ -1277,6 +1277,12 @@ block_dev_desc_t *mmc_get_dev(int dev)
>> }
>> #endif
>>
>> +/* board-specific MMC power initializations. */
>> +__weak int board_mmc_power_init(void)
>> +{
>> + return -1;
>> +}
>
> Since we don't check error return here which I think is fine just make
> this a void? Thanks!
There is v3 posted a while ago...
We have also agreed on v4..
- --
Regards,
Igor.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBAgAGBQJUWRPOAAoJEBDE8YO64EfafPsP/iow4r72B6oCuDDh7g9+BWYg
bO17RVU3PM14YgWQpybf/MXPgBSxyW3/4d69xrH5+TqEi9lOsHA/5X7ZW9r+xJh1
/JW1qwPKvqN9NdtGyPJppS0umoQoV77CzeTlLIdZ9emtozGSB/PpevAYK89HmrGl
g5XYzeX/uPPE9MrJ1GdeEk+bGSq3N7rSEAzWIiJ50Ai7A4t1RTYRtNAqMbf4q/Ip
WMO/MPiJk6Ybugk5vd91pJQkPtLIuFFEipUnIC8TSO7U8vWiOXKGgjH+aRvFhaLm
8YfU4Ym2vYZzIvpYbgHO6e2tKH0OhyzE/zZIDIGhOaXwPUsMbJquAvVEKz07XNu/
nOAeiBBhvTeMPehUe7jYaCymhxHJb3ZM29MOfz33a/GBskdMCNBtb/XoaibWbG1k
ZfIMktv0SDObRmd/eUCNvl09YWj8JB7aTzFg20ZoeLoyfW7S1aJ1L0AymaOY20n0
A7MXpEVU1ddPu1rIh9hKm8G86i04aarQJ0kJ4vooCZI+qPLndwH+6Go0Zny3Vbj5
v1SudRROl0KUIoJd/Lt5nmJgCsFsas9xXgJsQNuK3avRrwlPcTykJv1eHbYFlNTq
iFCjDAP7IU1iH0NBuJo7T2qPwPw9UMb3AQmo1JY/rFXopTVt2r0mkulZlAoMfWwy
L2cveucMAOGnEIFxhngN
=acIT
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-11-04 17:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 17:25 [U-Boot] [PATCH] omap_hsmmc: Allow for board-specific MMC power init Paul Kocialkowski
2014-10-28 18:02 ` Igor Grinberg
2014-10-28 18:11 ` Paul Kocialkowski
2014-10-29 13:10 ` Igor Grinberg
2014-10-30 15:28 ` Pantelis Antoniou
2014-11-01 10:35 ` [U-Boot] [PATCH v2 1/2] mmc: Board-specific MMC power initializations Paul Kocialkowski
2014-11-01 10:35 ` [U-Boot] [PATCH v2 2/2] omap_hsmmc: Board-specific TWL4030 " Paul Kocialkowski
2014-11-04 15:56 ` Tom Rini
2014-11-05 17:37 ` Paul Kocialkowski
2014-11-04 15:56 ` [U-Boot] [PATCH v2 1/2] mmc: Board-specific " Tom Rini
2014-11-04 17:58 ` Igor Grinberg [this message]
2014-11-04 18:32 ` Tom Rini
2014-11-05 17:35 ` Paul Kocialkowski
2014-11-05 17:46 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545913CE.6020609@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox