From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] mtd: nor: initialize writebufsize field
Date: Wed, 05 Nov 2014 08:00:21 +0100 [thread overview]
Message-ID: <5459CB05.5060405@denx.de> (raw)
In-Reply-To: <1415117278-1255-2-git-send-email-andrew.ruder@elecsyscorp.com>
Hello Andrew,
Am 04.11.2014 17:07, schrieb Andrew Ruder:
> UBI drivers error out if writebufsize is not filled in correctly. Grab
> this information from the CFI flash_info struct.
>
> Signed-off-by: Andrew Ruder<andrew.ruder@elecsyscorp.com>
> Cc: Wolfgang Denk<wd@denx.de>
> Cc: Heiko Schocher<hs@denx.de>
> Cc: Stefan Roese<sr@denx.de>
> ---
> drivers/mtd/cfi_mtd.c | 1 +
> 1 file changed, 1 insertion(+)
Patch already posted on the ML, see [1]
If this Patch works for you, could you send an "Acked-by" for it?
>
> diff --git a/drivers/mtd/cfi_mtd.c b/drivers/mtd/cfi_mtd.c
> index ac805ff..d4c9609 100644
> --- a/drivers/mtd/cfi_mtd.c
> +++ b/drivers/mtd/cfi_mtd.c
> @@ -226,6 +226,7 @@ int cfi_mtd_init(void)
> mtd->flags = MTD_CAP_NORFLASH;
> mtd->size = fi->size;
> mtd->writesize = 1;
> + mtd->writebufsize = fi->buffer_size;
^ should be cfi
This is a typo ... your patch would not compile ... please just
ack the patch [1], thanks!
bye,
Heiko
[1] Patchwork [U-Boot,v2] mtd, cfi, ubi: add missing writebufsize initialization
http://patchwork.ozlabs.org/patch/405260/
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2014-11-05 7:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 16:07 [U-Boot] [PATCH 1/2] ubi: enable error reporting in initialization Andrew Ruder
2014-11-04 16:07 ` [U-Boot] [PATCH 2/2] mtd: nor: initialize writebufsize field Andrew Ruder
2014-11-05 7:00 ` Heiko Schocher [this message]
2014-11-05 19:23 ` Andrew Ruder
2014-11-06 7:07 ` Heiko Schocher
2014-11-05 6:57 ` [U-Boot] [PATCH 1/2] ubi: enable error reporting in initialization Heiko Schocher
2014-11-05 14:27 ` Andrew Ruder
2014-11-05 15:12 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5459CB05.5060405@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox