* [U-Boot] [PATCH] doc: fix documentation of output directory
@ 2014-11-04 10:56 Timo Ketola
2014-11-05 7:16 ` Masahiro Yamada
0 siblings, 1 reply; 6+ messages in thread
From: Timo Ketola @ 2014-11-04 10:56 UTC (permalink / raw)
To: u-boot
Correct environment variable is KBUILD_OUTPUT.
Signed-off-by: Timo Ketola <timo@exertus.fi>
---
README | 6 +++---
doc/README.kwbimage | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/README b/README
index 7b5538e..c3a9dfc 100644
--- a/README
+++ b/README
@@ -5012,14 +5012,14 @@ this behavior and build U-Boot to some external directory:
make O=/tmp/build NAME_defconfig
make O=/tmp/build all
-2. Set environment variable BUILD_DIR to point to the desired location:
+2. Set environment variable KBUILD_OUTPUT to point to the desired location:
- export BUILD_DIR=/tmp/build
+ export KBUILD_OUTPUT=/tmp/build
make distclean
make NAME_defconfig
make all
-Note that the command line "O=" setting overrides the BUILD_DIR environment
+Note that the command line "O=" setting overrides the KBUILD_OUTPUT environment
variable.
diff --git a/doc/README.kwbimage b/doc/README.kwbimage
index 13f6f92..8c02298 100644
--- a/doc/README.kwbimage
+++ b/doc/README.kwbimage
@@ -30,10 +30,10 @@ kwbimage support available with mkimage utility will generate kirkwood boot
image that can be flashed on the board NAND/SPI flash. The make target
which uses mkimage to produce such an image is "u-boot.kwb". For example:
- export BUILD_DIR=/tmp/build
+ export KBUILD_OUTPUT=/tmp/build
make distclean
make yourboard_config
- make $BUILD_DIR/u-boot.kwb
+ make $KBUILD_OUTPUT/u-boot.kwb
Board specific configuration file specifications:
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] doc: fix documentation of output directory
2014-11-04 10:56 [U-Boot] [PATCH] doc: fix documentation of output directory Timo Ketola
@ 2014-11-05 7:16 ` Masahiro Yamada
2014-11-05 8:12 ` Timo Ketola
0 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2014-11-05 7:16 UTC (permalink / raw)
To: u-boot
Hi Timo,
On Tue, 4 Nov 2014 12:56:50 +0200
Timo Ketola <timo@exertus.fi> wrote:
>
> diff --git a/doc/README.kwbimage b/doc/README.kwbimage
> index 13f6f92..8c02298 100644
> --- a/doc/README.kwbimage
> +++ b/doc/README.kwbimage
> @@ -30,10 +30,10 @@ kwbimage support available with mkimage utility will generate kirkwood boot
> image that can be flashed on the board NAND/SPI flash. The make target
> which uses mkimage to produce such an image is "u-boot.kwb". For example:
>
> - export BUILD_DIR=/tmp/build
> + export KBUILD_OUTPUT=/tmp/build
Correct.
> make distclean
> make yourboard_config
> - make $BUILD_DIR/u-boot.kwb
> + make $KBUILD_OUTPUT/u-boot.kwb
>
>
Should be
make yourboard_defconfig
make u-boot.kwb
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] doc: fix documentation of output directory
2014-11-05 7:16 ` Masahiro Yamada
@ 2014-11-05 8:12 ` Timo Ketola
2014-11-05 14:25 ` Masahiro YAMADA
0 siblings, 1 reply; 6+ messages in thread
From: Timo Ketola @ 2014-11-05 8:12 UTC (permalink / raw)
To: u-boot
On 05.11.2014 09:16, Masahiro Yamada wrote:
> On Tue, 4 Nov 2014 12:56:50 +0200
> Timo Ketola <timo@exertus.fi> wrote:
>> make distclean
>> make yourboard_config
>> - make $BUILD_DIR/u-boot.kwb
>> + make $KBUILD_OUTPUT/u-boot.kwb
>
> Should be
> make yourboard_defconfig
> make u-boot.kwb
Sounds logical. But that means that the older version was already broken
(even when BUILD_DIR was correct variable), doesn't it?
Should I edit the patch that way or leave the file alone?
--
Timo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] doc: fix documentation of output directory
2014-11-05 8:12 ` Timo Ketola
@ 2014-11-05 14:25 ` Masahiro YAMADA
2014-11-06 12:39 ` [U-Boot] [PATCH v2] doc: fix documentation of out-of-tree build Timo Ketola
0 siblings, 1 reply; 6+ messages in thread
From: Masahiro YAMADA @ 2014-11-05 14:25 UTC (permalink / raw)
To: u-boot
Hi Timo,
2014-11-05 17:12 GMT+09:00 Timo Ketola <Timo.Ketola@exertus.fi>:
> On 05.11.2014 09:16, Masahiro Yamada wrote:
>> On Tue, 4 Nov 2014 12:56:50 +0200
>> Timo Ketola <timo@exertus.fi> wrote:
>>> make distclean
>>> make yourboard_config
>>> - make $BUILD_DIR/u-boot.kwb
>>> + make $KBUILD_OUTPUT/u-boot.kwb
>>
>> Should be
>> make yourboard_defconfig
>> make u-boot.kwb
>
> Sounds logical. But that means that the older version was already broken
> (even when BUILD_DIR was correct variable), doesn't it?
>
> Should I edit the patch that way or leave the file alone?
>
Both "make $BUILD_DIR/u-boot.kwb" and "make
"$KBUILD_OUTPUT/u-boot.kwb" are wrong.
"make u-boot.kwb" is correct.
Please fix the patch as I suggested.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2] doc: fix documentation of out-of-tree build
2014-11-05 14:25 ` Masahiro YAMADA
@ 2014-11-06 12:39 ` Timo Ketola
2014-11-10 21:27 ` [U-Boot] [U-Boot, " Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Timo Ketola @ 2014-11-06 12:39 UTC (permalink / raw)
To: u-boot
Correct environment variable for output directory is KBUILD_OUTPUT.
Signed-off-by: Timo Ketola <timo@exertus.fi>
---
v2 changes:
- Fixed the example in the doc/README.kwbimage file functionally
correct
README | 6 +++---
doc/README.kwbimage | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/README b/README
index 7b5538e..c3a9dfc 100644
--- a/README
+++ b/README
@@ -5012,14 +5012,14 @@ this behavior and build U-Boot to some external directory:
make O=/tmp/build NAME_defconfig
make O=/tmp/build all
-2. Set environment variable BUILD_DIR to point to the desired location:
+2. Set environment variable KBUILD_OUTPUT to point to the desired location:
- export BUILD_DIR=/tmp/build
+ export KBUILD_OUTPUT=/tmp/build
make distclean
make NAME_defconfig
make all
-Note that the command line "O=" setting overrides the BUILD_DIR environment
+Note that the command line "O=" setting overrides the KBUILD_OUTPUT environment
variable.
diff --git a/doc/README.kwbimage b/doc/README.kwbimage
index 13f6f92..762b2e3 100644
--- a/doc/README.kwbimage
+++ b/doc/README.kwbimage
@@ -30,10 +30,10 @@ kwbimage support available with mkimage utility will generate kirkwood boot
image that can be flashed on the board NAND/SPI flash. The make target
which uses mkimage to produce such an image is "u-boot.kwb". For example:
- export BUILD_DIR=/tmp/build
+ export KBUILD_OUTPUT=/tmp/build
make distclean
make yourboard_config
- make $BUILD_DIR/u-boot.kwb
+ make u-boot.kwb
Board specific configuration file specifications:
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-11-10 21:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-04 10:56 [U-Boot] [PATCH] doc: fix documentation of output directory Timo Ketola
2014-11-05 7:16 ` Masahiro Yamada
2014-11-05 8:12 ` Timo Ketola
2014-11-05 14:25 ` Masahiro YAMADA
2014-11-06 12:39 ` [U-Boot] [PATCH v2] doc: fix documentation of out-of-tree build Timo Ketola
2014-11-10 21:27 ` [U-Boot] [U-Boot, " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox