public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 1/2] ppc4xx: Fix i2c repeated start
Date: Wed, 05 Nov 2014 11:35:52 +0100	[thread overview]
Message-ID: <5459FD88.4050608@denx.de> (raw)
In-Reply-To: <1414594604-30219-2-git-send-email-dirk.eibach@gdsys.cc>

On 29.10.2014 15:56, dirk.eibach at gdsys.cc wrote:
> From: Dirk Eibach <dirk.eibach@gdsys.cc>
>
> Debugging some i2c trouble I saw on my scope that repeated
> start is not working properply. The 4xx even held clock pulled down
> after transfers. Having a look in the driver I realized
> that IIC_CNTL_RPST is set on that part of the transfer that should
> begin with a repeated start. But repeated start is about not sending a
> stop condition, so IIC_CNTL_RPST has to be set on the last transfer
> before the repeated start happens.
>
> Signed-off-by: Dirk Eibach <dirk.eibach@gdsys.cc>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

  reply	other threads:[~2014-11-05 10:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29 14:56 [U-Boot] [PATCH v1 0/2] Fix some ppc4xx i2c controller issues dirk.eibach at gdsys.cc
2014-10-29 14:56 ` [U-Boot] [PATCH v1 1/2] ppc4xx: Fix i2c repeated start dirk.eibach at gdsys.cc
2014-11-05 10:35   ` Stefan Roese [this message]
2014-10-29 14:56 ` [U-Boot] [PATCH v1 2/2] ppc4xx: Handle i2c stuck on combined xfer dirk.eibach at gdsys.cc
2014-10-30  6:55   ` Heiko Schocher
2014-10-30  6:58     ` Dirk Eibach
2014-11-05 10:36   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5459FD88.4050608@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox