* [U-Boot] [u-boot][PATCH] omap3_beagle: Fix device tree boot
@ 2014-11-05 13:57 Roger Quadros
2014-11-05 14:18 ` Tom Rini
0 siblings, 1 reply; 7+ messages in thread
From: Roger Quadros @ 2014-11-05 13:57 UTC (permalink / raw)
To: u-boot
Push the device tree blob load address (fdtaddr) further apart than
kernel load address (loadaddr) to accomodate a larger kernel image.
We set fdtaddr to the same value as set in ti_armv7_common.h.
With this change, I'm able to boot linux-3.18-rc1 zImage built using
omap2plus_defconfig.
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
include/configs/omap3_beagle.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
index f25a940..5ea048a 100644
--- a/include/configs/omap3_beagle.h
+++ b/include/configs/omap3_beagle.h
@@ -132,7 +132,7 @@
"loadaddr=0x80200000\0" \
"rdaddr=0x81000000\0" \
"fdt_high=0xffffffff\0" \
- "fdtaddr=0x80f80000\0" \
+ "fdtaddr=0x88000000\0" \
"usbtty=cdc_acm\0" \
"bootfile=uImage\0" \
"ramdisk=ramdisk.gz\0" \
--
1.8.3.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [u-boot][PATCH] omap3_beagle: Fix device tree boot
2014-11-05 13:57 [U-Boot] [u-boot][PATCH] omap3_beagle: Fix device tree boot Roger Quadros
@ 2014-11-05 14:18 ` Tom Rini
2014-11-05 14:25 ` Roger Quadros
0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2014-11-05 14:18 UTC (permalink / raw)
To: u-boot
On Wed, Nov 05, 2014 at 03:57:34PM +0200, Roger Quadros wrote:
> Push the device tree blob load address (fdtaddr) further apart than
> kernel load address (loadaddr) to accomodate a larger kernel image.
> We set fdtaddr to the same value as set in ti_armv7_common.h.
>
> With this change, I'm able to boot linux-3.18-rc1 zImage built using
> omap2plus_defconfig.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> include/configs/omap3_beagle.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> index f25a940..5ea048a 100644
> --- a/include/configs/omap3_beagle.h
> +++ b/include/configs/omap3_beagle.h
> @@ -132,7 +132,7 @@
> "loadaddr=0x80200000\0" \
> "rdaddr=0x81000000\0" \
> "fdt_high=0xffffffff\0" \
> - "fdtaddr=0x80f80000\0" \
> + "fdtaddr=0x88000000\0" \
While we're in here whacking these values lets make this match up the
rest of the values we use in ti_armv7_common.h (so drop fdt_high and set
bootm_size and so forth). Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141105/444c8be8/attachment.pgp>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [u-boot][PATCH] omap3_beagle: Fix device tree boot
2014-11-05 14:18 ` Tom Rini
@ 2014-11-05 14:25 ` Roger Quadros
2014-11-05 15:23 ` Tom Rini
0 siblings, 1 reply; 7+ messages in thread
From: Roger Quadros @ 2014-11-05 14:25 UTC (permalink / raw)
To: u-boot
On 11/05/2014 04:18 PM, Tom Rini wrote:
> On Wed, Nov 05, 2014 at 03:57:34PM +0200, Roger Quadros wrote:
>
>> Push the device tree blob load address (fdtaddr) further apart than
>> kernel load address (loadaddr) to accomodate a larger kernel image.
>> We set fdtaddr to the same value as set in ti_armv7_common.h.
>>
>> With this change, I'm able to boot linux-3.18-rc1 zImage built using
>> omap2plus_defconfig.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>> include/configs/omap3_beagle.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
>> index f25a940..5ea048a 100644
>> --- a/include/configs/omap3_beagle.h
>> +++ b/include/configs/omap3_beagle.h
>> @@ -132,7 +132,7 @@
>> "loadaddr=0x80200000\0" \
>> "rdaddr=0x81000000\0" \
>> "fdt_high=0xffffffff\0" \
>> - "fdtaddr=0x80f80000\0" \
>> + "fdtaddr=0x88000000\0" \
>
> While we're in here whacking these values lets make this match up the
> rest of the values we use in ti_armv7_common.h (so drop fdt_high and set
> bootm_size and so forth). Thanks!
>
It seems like omap3_beagle.h includes ti_omap3_common.h which in turn includes
ti_armv7_common.h.
So I just need to remove the duplicate definitions from omap3_beagle.h
cheers,
-roger
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [u-boot][PATCH] omap3_beagle: Fix device tree boot
2014-11-05 14:25 ` Roger Quadros
@ 2014-11-05 15:23 ` Tom Rini
0 siblings, 0 replies; 7+ messages in thread
From: Tom Rini @ 2014-11-05 15:23 UTC (permalink / raw)
To: u-boot
On Wed, Nov 05, 2014 at 04:25:55PM +0200, Roger Quadros wrote:
> On 11/05/2014 04:18 PM, Tom Rini wrote:
> > On Wed, Nov 05, 2014 at 03:57:34PM +0200, Roger Quadros wrote:
> >
> >> Push the device tree blob load address (fdtaddr) further apart than
> >> kernel load address (loadaddr) to accomodate a larger kernel image.
> >> We set fdtaddr to the same value as set in ti_armv7_common.h.
> >>
> >> With this change, I'm able to boot linux-3.18-rc1 zImage built using
> >> omap2plus_defconfig.
> >>
> >> Signed-off-by: Roger Quadros <rogerq@ti.com>
> >> ---
> >> include/configs/omap3_beagle.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> >> index f25a940..5ea048a 100644
> >> --- a/include/configs/omap3_beagle.h
> >> +++ b/include/configs/omap3_beagle.h
> >> @@ -132,7 +132,7 @@
> >> "loadaddr=0x80200000\0" \
> >> "rdaddr=0x81000000\0" \
> >> "fdt_high=0xffffffff\0" \
> >> - "fdtaddr=0x80f80000\0" \
> >> + "fdtaddr=0x88000000\0" \
> >
> > While we're in here whacking these values lets make this match up the
> > rest of the values we use in ti_armv7_common.h (so drop fdt_high and set
> > bootm_size and so forth). Thanks!
> >
> It seems like omap3_beagle.h includes ti_omap3_common.h which in turn includes
> ti_armv7_common.h.
>
> So I just need to remove the duplicate definitions from omap3_beagle.h
And references DEFAULT_LINUX_BOOT_ENV :)
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141105/33a5b27f/attachment.pgp>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [u-boot][PATCH] omap3_beagle: Fix device tree boot
@ 2015-03-06 15:34 Roger Quadros
2015-03-06 16:28 ` Tom Rini
0 siblings, 1 reply; 7+ messages in thread
From: Roger Quadros @ 2015-03-06 15:34 UTC (permalink / raw)
To: u-boot
Don't redefine fdtaddr and other values that are already defined in
ti_armv7_common.h. The value of fdtaddr in ti_armv7_common.h is
more appropriate as it allows a larger kernel image to be loaded.
With this change, I'm able to boot linux-4.0-rc1 with device tree blob.
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
include/configs/omap3_beagle.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
index f25a940..3ea9b08 100644
--- a/include/configs/omap3_beagle.h
+++ b/include/configs/omap3_beagle.h
@@ -129,10 +129,8 @@
/* devices */
#define CONFIG_EXTRA_ENV_SETTINGS \
- "loadaddr=0x80200000\0" \
- "rdaddr=0x81000000\0" \
+ DEFAULT_LINUX_BOOT_ENV \
"fdt_high=0xffffffff\0" \
- "fdtaddr=0x80f80000\0" \
"usbtty=cdc_acm\0" \
"bootfile=uImage\0" \
"ramdisk=ramdisk.gz\0" \
--
2.1.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [u-boot][PATCH] omap3_beagle: Fix device tree boot
2015-03-06 15:34 Roger Quadros
@ 2015-03-06 16:28 ` Tom Rini
2015-03-09 12:14 ` Roger Quadros
0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2015-03-06 16:28 UTC (permalink / raw)
To: u-boot
On Fri, Mar 06, 2015 at 05:34:24PM +0200, Roger Quadros wrote:
> Don't redefine fdtaddr and other values that are already defined in
> ti_armv7_common.h. The value of fdtaddr in ti_armv7_common.h is
> more appropriate as it allows a larger kernel image to be loaded.
>
> With this change, I'm able to boot linux-4.0-rc1 with device tree blob.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> include/configs/omap3_beagle.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> index f25a940..3ea9b08 100644
> --- a/include/configs/omap3_beagle.h
> +++ b/include/configs/omap3_beagle.h
> @@ -129,10 +129,8 @@
> /* devices */
>
> #define CONFIG_EXTRA_ENV_SETTINGS \
> - "loadaddr=0x80200000\0" \
> - "rdaddr=0x81000000\0" \
> + DEFAULT_LINUX_BOOT_ENV \
> "fdt_high=0xffffffff\0" \
> - "fdtaddr=0x80f80000\0" \
> "usbtty=cdc_acm\0" \
> "bootfile=uImage\0" \
> "ramdisk=ramdisk.gz\0" \
With DEFAULT_LINUX_BOOT_ENV the bootm_size variable makes sure that we
relocate the DT within the area that the kernel will see and we don't
need fdt_high being set either.
--
Tom
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [u-boot][PATCH] omap3_beagle: Fix device tree boot
2015-03-06 16:28 ` Tom Rini
@ 2015-03-09 12:14 ` Roger Quadros
0 siblings, 0 replies; 7+ messages in thread
From: Roger Quadros @ 2015-03-09 12:14 UTC (permalink / raw)
To: u-boot
Tom,
On 06/03/15 18:28, Tom Rini wrote:
> On Fri, Mar 06, 2015 at 05:34:24PM +0200, Roger Quadros wrote:
>
>> Don't redefine fdtaddr and other values that are already defined in
>> ti_armv7_common.h. The value of fdtaddr in ti_armv7_common.h is
>> more appropriate as it allows a larger kernel image to be loaded.
>>
>> With this change, I'm able to boot linux-4.0-rc1 with device tree blob.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>> include/configs/omap3_beagle.h | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
>> index f25a940..3ea9b08 100644
>> --- a/include/configs/omap3_beagle.h
>> +++ b/include/configs/omap3_beagle.h
>> @@ -129,10 +129,8 @@
>> /* devices */
>>
>> #define CONFIG_EXTRA_ENV_SETTINGS \
>> - "loadaddr=0x80200000\0" \
>> - "rdaddr=0x81000000\0" \
>> + DEFAULT_LINUX_BOOT_ENV \
>> "fdt_high=0xffffffff\0" \
>> - "fdtaddr=0x80f80000\0" \
>> "usbtty=cdc_acm\0" \
>> "bootfile=uImage\0" \
>> "ramdisk=ramdisk.gz\0" \
>
> With DEFAULT_LINUX_BOOT_ENV the bootm_size variable makes sure that we
> relocate the DT within the area that the kernel will see and we don't
> need fdt_high being set either.
>
I tried without fdt_high and the board wasn't booting. So we're still missing
something for the omap3_beagle w.r.t that.
Any clues?
cheers,
-roger
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-03-09 12:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-05 13:57 [U-Boot] [u-boot][PATCH] omap3_beagle: Fix device tree boot Roger Quadros
2014-11-05 14:18 ` Tom Rini
2014-11-05 14:25 ` Roger Quadros
2014-11-05 15:23 ` Tom Rini
-- strict thread matches above, loose matches on Subject: below --
2015-03-06 15:34 Roger Quadros
2015-03-06 16:28 ` Tom Rini
2015-03-09 12:14 ` Roger Quadros
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox