public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ot1200: fix sf detection
Date: Wed, 05 Nov 2014 15:57:17 +0100	[thread overview]
Message-ID: <545A3ACD.4040303@denx.de> (raw)
In-Reply-To: <20141022120937.388e9fb2@crub>

Hello Anatolij,

Am 22.10.2014 12:09, schrieb Anatolij Gustschin:
> Hi all,
>
> On Wed, 22 Oct 2014 11:29:51 +0200
> Christian Gmeiner<christian.gmeiner@gmail.com>  wrote:
>
>> Commit 155fa9af95ac5be857a7327e7a968a296e60d4c8 changed the way
>> to define a GPIO line, which can be used to force CS high
>> across multiple transactions. In order to fix sf detection
>> change board code to make use of board_spi_cs_gpio(..).
>>
>> Signed-off-by: Christian Gmeiner<christian.gmeiner@gmail.com>
>> ---
>>   board/bachmann/ot1200/ot1200.c | 5 +++++
>>   include/configs/ot1200.h       | 2 +-
>>   2 files changed, 6 insertions(+), 1 deletion(-)
>
>
> There are another two board that might be affected:
>
> $ grep --exclude=ot1200.h -r SF_DEFAULT_CS include/configs/ | grep IMX_GPIO_NR
> include/configs/aristainetos.h:#define CONFIG_SF_DEFAULT_CS		(0|(IMX_GPIO_NR(3, 20)<<8))
> include/configs/tqma6.h:#define CONFIG_SF_DEFAULT_CS	(0 | (IMX_GPIO_NR(3, 19)<<  8))
>
> So, I'm CC'ing board maintainers, please test/fix them too. Thanks!

thanks for adding me to cc !

I fix this issue here:

http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commit;h=2f6bb0a9419ec8016524142cb54fef81038b346e

already applied in the u-boot.imx tree ...

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2014-11-05 14:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22  9:29 [U-Boot] [PATCH] ot1200: fix sf detection Christian Gmeiner
2014-10-22  9:35 ` Stefano Babic
2014-10-22 10:09 ` Anatolij Gustschin
2014-11-05 14:57   ` Heiko Schocher [this message]
2014-10-22 13:18 ` Nikita Kiryanov
2014-10-23  8:03 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545A3ACD.4040303@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox