public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Steve Rae <srae@broadcom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] buildman: using wrong libgcc.a
Date: Wed, 5 Nov 2014 09:22:01 -0800	[thread overview]
Message-ID: <545A5CB9.7090906@broadcom.com> (raw)
In-Reply-To: <CAPnjgZ0qPrL4cYhDTGAyN=OHQRukbR7xZoi1R_9+bQpgrkTo6g@mail.gmail.com>



On 14-11-03 01:14 PM, Simon Glass wrote:
> Hi,
>
> On 30 October 2014 14:57, Jeroen Hofstee <jeroen@myspectrum.nl> wrote:
>> Hello Steve,
>>
>> On 30-10-14 21:42, Steve Rae wrote:
>>>
>>> Hmmmm -- maybe it would be better to specify the entire path for the
>>> CROSS_COMPILE, and not rely on the PATH to find the cross compile tools:
>>>
>>> diff --git a/tools/buildman/toolchain.py b/tools/buildman/toolchain.py
>>> index 27dc318..58c7b1f 100644
>>> --- a/tools/buildman/toolchain.py
>>> +++ b/tools/buildman/toolchain.py
>>> @@ -33,6 +33,7 @@ class Toolchain:
>>>           self.cross = os.path.basename(fname)[:-3]
>>>           pos = self.cross.find('-')
>>>           self.arch = self.cross[:pos] if pos != -1 else 'sandbox'
>>> +        self.cross = fname[:-3]
>>>
>>
>> A bit off topic, but is it possible to stop adding these magic 3
>> constants. strlen("clang") != 3. strlen("cc") isn't either. Anyway
>> I am aware buildman is already full with it, so I am fine with
>> one more (for now).
>
> This should be isolated to Toolchain. I'd be happy to have a fix that
> solves this once and for all. What is needed?
>
> Regards,
> Simon
>
( back to the original issue )
diff --git a/tools/buildman/toolchain.py b/tools/buildman/toolchain.py
index 27dc318..58c7b1f 100644
--- a/tools/buildman/toolchain.py
+++ b/tools/buildman/toolchain.py
@@ -33,6 +33,7 @@ class Toolchain:
          self.cross = os.path.basename(fname)[:-3]
          pos = self.cross.find('-')
          self.arch = self.cross[:pos] if pos != -1 else 'sandbox'
+        self.cross = fname[:-3]

          env = self.MakeEnvironment()


@@ -82,7 +83,6 @@ class Toolchain:
          """
          env = dict(os.environ)
          env['CROSS_COMPILE'] = self.cross
-        env['PATH'] += (':' + self.path)
          return env

This solves my problem, however, I have only built "arm" and "armv8" 
targets....
So I don't know whether it breaks any other environments.
How can we proceed?
Thanks, Steve

  reply	other threads:[~2014-11-05 17:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-30 16:57 [U-Boot] buildman: using wrong libgcc.a Steve Rae
2014-10-30 20:42 ` Steve Rae
2014-10-30 20:57   ` Jeroen Hofstee
2014-11-03 21:14     ` Simon Glass
2014-11-05 17:22       ` Steve Rae [this message]
2014-11-05 18:46       ` Jeroen Hofstee
2014-11-05 19:05         ` [U-Boot] buildman: using wrong libgcc.a (magic -3) Steve Rae
2014-11-05 19:09           ` Wolfgang Denk
2014-11-05 19:36             ` Steve Rae
2014-11-05 22:59               ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545A5CB9.7090906@broadcom.com \
    --to=srae@broadcom.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox